Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ Hybrid Solver: Allow parameters as Rate Rule variables #692

Open
jtcooper10 opened this issue Jan 19, 2022 · 1 comment
Open

C++ Hybrid Solver: Allow parameters as Rate Rule variables #692

jtcooper10 opened this issue Jan 19, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jtcooper10
Copy link
Collaborator

Currently, Parameter objects are not allowed in Rate Rules for the TauHybridCSolver. This should be allowed.

Required Changes

  • Update the template generation code to distinguish between Parameter and Species objects.
  • Modify the C++ implementation of rate rules to allow parameters as targets.
@BryanRumsey BryanRumsey added the enhancement New feature or request label Apr 14, 2022
@BryanRumsey BryanRumsey added this to To-Do in Release 1.7.0 via automation Apr 14, 2022
@BryanRumsey BryanRumsey added this to the 1.6.10 milestone Apr 14, 2022
@BryanRumsey BryanRumsey modified the milestones: 1.6.10, 1.6.11 Jun 28, 2022
@BryanRumsey BryanRumsey removed this from To-Do in Release 1.7.0 Jun 28, 2022
@BryanRumsey BryanRumsey added this to To-Do in Release 1.6.11 via automation Jun 28, 2022
@BryanRumsey BryanRumsey modified the milestones: 1.6.11, 1.7.1 Aug 15, 2022
@BryanRumsey BryanRumsey removed this from To-Do in Release 1.6.11 Aug 15, 2022
@BryanRumsey BryanRumsey added this to To-Do in Release 1.7.1 via automation Aug 15, 2022
@BryanRumsey BryanRumsey removed this from To-Do in Release 1.7.1 Oct 5, 2022
@BryanRumsey BryanRumsey added this to To-Do in Release 1.7.2 via automation Oct 5, 2022
@BryanRumsey BryanRumsey modified the milestones: 1.7.1, 1.7.2 Oct 5, 2022
@briandrawert
Copy link
Member

test_issue_692.zip
Testing notebook

@briandrawert briandrawert removed this from To-Do in Release 1.7.2 Dec 21, 2022
@briandrawert briandrawert added this to To-Do in Release 1.8.0 via automation Dec 21, 2022
@BryanRumsey BryanRumsey removed this from To-Do in Release 1.8.0 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

692-c++-hybrid-solver-allow-parameters-as-rate-rule-variables StochSS/GillesPy2
3 participants
@briandrawert @jtcooper10 @BryanRumsey