Remove all binaries #324
Closed
Remove all binaries #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are no longer needed, since they can be easily generated from source now. Closes Stephane-D#297
|
JFYI, builds are failing in CI until #322 is merged. |
|
The whole idea of the bin folder is to have prebuild binaries ready to use for windows ! |
|
I respect your right to make whatever decision you want for your project, but the way most projects would handle this is by having binaries in GitHub releases. Someone would generally download a release with binaries, or clone source and build binaries, but generally not clone the repo for prebuilt binaries. If you don't intend to change this, please update #297 with your reasoning and close it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are no longer needed, since they can be easily generated from source now.
Closes #297