Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depotmanifest.Serialize() should be made public. #1354

Open
nightshadow92 opened this issue Apr 22, 2024 · 2 comments
Open

Depotmanifest.Serialize() should be made public. #1354

nightshadow92 opened this issue Apr 22, 2024 · 2 comments

Comments

@nightshadow92
Copy link

What problem is this feature trying to solve?

Currently, the only way to save DepotManifest is using SaveToFile(), making Serialize() public would allow alternatives.

How would you like it to be solved?

Make the Serialize() function in DepotManifest public.

Have you considered any alternative solutions

No.

Additional Information

No response

@xPaw
Copy link
Member

xPaw commented Apr 23, 2024

Serialize() should accept a Stream (which removes the internal MemoryStream), and then SaveToFile can pass the file stream directly in, and then an overload can be added like SaveToStream (for consistency) which just calls Serialize.

PRs welcome.

@skylayer
Copy link

I've implemented a potential solution for this. Please see PR #1337 for a minimalistic approach that addresses the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants