Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

found 1 moderate severity vulnerability #197

Open
pradiptadas115 opened this issue Sep 2, 2019 · 4 comments
Open

found 1 moderate severity vulnerability #197

pradiptadas115 opened this issue Sep 2, 2019 · 4 comments

Comments

@pradiptadas115
Copy link

I can see an issue of " hubot-stackstorm" package installation :

root@bef5e65692ca:/myhubot# npm install hubot-stackstorm
npm WARN deprecated coffee-script@1.12.7: CoffeeScript on NPM has moved to "coffeescript" (no hyphen)

  • hubot-stackstorm@0.10.0
    added 27 packages from 61 contributors and audited 305 packages in 10.924s
    found 1 moderate severity vulnerability
    run npm audit fix to fix them, or npm audit for details
    root@bef5e65692ca:/myhubot# ^C
    root@bef5e65692ca:/myhubot# npm audit fix
    up to date in 1.29s
    fixed 0 of 1 vulnerability in 305 scanned packages
    1 vulnerability required manual review and could not be updated
@arm4b
Copy link
Member

arm4b commented Sep 10, 2019

Thanks for the report,

It's caused by outdated dependencies we're using in https://github.com/StackStorm/st2client.js
Related PR that failed to update it: StackStorm/st2client.js#68

This is still a valid issue.

@arm4b
Copy link
Member

arm4b commented Apr 21, 2020

Currently there are 2 security issues for hubot-stackstorm due to dependencies:

First is axios, which should be fixed in StackStorm/st2client.js#76, thanks to @bgaeddert

Second is lodash.template

@arm4b arm4b added this to TODO in StackStorm v3.2.1 via automation Apr 22, 2020
@punkrokk punkrokk removed this from TODO in StackStorm v3.2.1 Jul 17, 2020
@punkrokk punkrokk added this to To do in StackStorm v3.3.0 via automation Jul 17, 2020
@blag
Copy link
Contributor

blag commented Sep 1, 2020

This issue is held up by hubot-slack, which still does not support coffeescript 2 at this point:

I don't think this is a security issue, but this is not one of the devDependencies.

I documented this in the README for st2chatops, which is maybe not the best place for that information to live. 😆

@nmaludy nmaludy removed this from To do in StackStorm v3.3.0 Oct 1, 2020
@nmaludy
Copy link
Member

nmaludy commented Oct 1, 2020

Removing from 3.3.0 until upstream changes in hubot have been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants