Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support responding in thread (Slack) #161

Open
shreyas-shinde opened this issue Feb 20, 2019 · 4 comments
Open

Support responding in thread (Slack) #161

shreyas-shinde opened this issue Feb 20, 2019 · 4 comments

Comments

@shreyas-shinde
Copy link

Hi,
I want to confirm if there is plan to support sending response from stackstorm to the command originating thread. Acknowledgement message from Hubot is sent in the same thread but response from chatops.post_message action is sent to channel instead of thread.

@shreyas-shinde
Copy link
Author

Proposal Solution:

  1. Set thread id here https://github.com/StackStorm/hubot-stackstorm/blob/master/lib/utils.js#L113
  2. Send it to stackstorm by including here https://github.com/StackStorm/hubot-stackstorm/blob/master/scripts/stackstorm.js#L294
  3. Update chatops.post_message to support thread_id param similar to channel https://github.com/StackStorm/st2/blob/master/contrib/chatops/actions/post_message.yaml#L24
  4. Update slack postdatahandler to send to correct thread https://github.com/StackStorm/hubot-stackstorm/blob/master/lib/post_data.js#L28

@LindsayHill
Copy link

I don't think anyone else has any plans to work on that, so go ahead and create a PR. The main thing to be aware of is not breaking non-Slack chat adapters.

@blag
Copy link
Contributor

blag commented Feb 20, 2019

Yes, I would be interested in a PR for this.

@nzlosh
Copy link
Contributor

nzlosh commented Feb 21, 2019

@shreyas-shinde since this is a Slack specific feature, is it possible to use the extra.slack parameter to pass the thread_id? This would avoid adding a non-generic parameter to chatops.post_message action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants