BUNNY_DNS: Error After Zone Creation (The Bunny is Too Fast)

[Silvenga]

Describe the bug

There appears to be a race condition in the Bunny DNS provider when a given zone needs to be created. From my testing, it looks like the following is happening:

• Zone detected as absent.
• Zone created, Bunny returns OK.
• NS's need to be queried for this newly created zone.
• An exception is thrown, as this zone does not exist (likely eventually consistent?).

To Reproduce

Steps to reproduce the behavior:

1. Configure the Bunny DNS (bunny_dns) provider.
2. Create a zone that does not exist in the Bunny account.
3. Observe that sometimes zone creation succeeds, but sometimes fails when querying for this zone again (in the same push operation). When a failure occurs, immediately attempting to push, succeeds.

#1: Create zone '<domain>' in the 'bunny_dns' profile
WARNING: BUNNY_DNS: Added zone <domain> with ID 206015SUCCESS!
INFO#1: Domain "<domain>" provider bunny_dns Error: "<domain>" is not a zone in this BUNNY_DNS account
INFO#1: DtermineNS: zone "<domain>"; Error: error while getting Nameservers for zone="<domain>" with provider="bunny_dns": "<domain>" is not a zone in this BUNNY_DNS account
Done. 1 corrections.

Expected behavior

Ideally, the provider should verify existence here and retry in the case the zone doesn't exist, likely with some pause.

dnscontrol/providers/bunnydns/listzones.go

Lines 19 to 32 in df1354b

	func (b *bunnydnsProvider) EnsureZoneExists(domain string) error {
	_, err := b.findZoneByDomain(domain)
	if err == nil {
	return nil
	}
	zone, err := b.createZone(domain)
	if err != nil {
	return err
	}
	printer.Warnf("BUNNY_DNS: Added zone %s with ID %d", domain, zone.ID)
	return nil
	}

DNS Provider

• Bunny DNS

Additional context

🐰

[tlimoncelli]

CC @ppmathis