Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement request throttling #98

Open
hkiame opened this issue Jul 28, 2023 · 4 comments
Open

Implement request throttling #98

hkiame opened this issue Jul 28, 2023 · 4 comments
Labels
new feature This is a new feature!

Comments

@hkiame
Copy link

hkiame commented Jul 28, 2023

Is your feature request related to a problem? Please describe.

When the user clicks the dream button multiple times rapidly, it triggers multiple requests simultaneously, instead of waiting for the first request to be processed

Describe the solution you'd like
Implement request throttling. You can use techniques like debouncing or disabling the submit button after the first click until the request is processed.

@hkiame hkiame added the new feature This is a new feature! label Jul 28, 2023
@KAJdev
Copy link
Contributor

KAJdev commented Jul 29, 2023

Throttling is already implemented. StableStudio will queue up requests and send one per second.

@hkiame
Copy link
Author

hkiame commented Jul 29, 2023

@KAJdev How about disabling the submit button after the first click until the request is processed? I would love to work on that. Please assign that to me

@KAJdev
Copy link
Contributor

KAJdev commented Jul 29, 2023

This would actually be removing parallel generations, which is a feature.

@hkiame
Copy link
Author

hkiame commented Jul 29, 2023

@KAJdev didn't know about that. I don't find it good to have the button enabled when there is a request being processed though. All the time I have had the button clicked the 2nd time when there is an going request is by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This is a new feature!
Projects
None yet
Development

No branches or pull requests

2 participants