Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PharoObjectModel - edit or delete references to 'Color>>initializeNames' #107

Open
dmitrizagidulin opened this issue Jun 20, 2015 · 1 comment

Comments

@dmitrizagidulin
Copy link
Collaborator

The end of the 'Class variables' section used the ColorNames class variable as an illustration of the shared nature of class variables. In Pharo 4, ColorNames has been replaced by ColorRegistry.

Which is fine, I changed the example to refer to ColorRegistry. But the last paragraph (currently commented out, see lines 1072-1074), mentioned that ColorNames is accessed from the instances of Color. Whereas the new ColorRegistry is primarily used by class methods in Color.

My question is, should we:

  1. Just omit that last paragraph, since we made our overall point without it
  2. Use some other class variable of Color
  3. Use a class other than Color (since in 4, it doesn't have any subclasses, for example) and another class variable?

/cc @Ducasse

@dmitrizagidulin dmitrizagidulin added this to the v4.0 - Update for Pharo 4.0 milestone Jun 28, 2015
@nicolaihess
Copy link
Collaborator

Yes the method Color>>name not even accesses this variable from the instance side.
Mybe class Cursor is a better example for class variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants