Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization TODOs #133

Open
1 of 4 tasks
buybackoff opened this issue Jun 28, 2018 · 0 comments
Open
1 of 4 tasks

Serialization TODOs #133

buybackoff opened this issue Jun 28, 2018 · 0 comments

Comments

@buybackoff
Copy link
Member

buybackoff commented Jun 28, 2018

  • SM/ArrayConverter JSON returns exact arrays that are not powers of two, that causes problems in SM dispose/pool return. We use Read<TElement[]>, should try ArraySegment<TElement[]> and tweak impl to use pooled arrays if it doesn't already.
  • Custom Utf8Json formatters to replace old Json.Net ones.
  • Unhappy paths, e.g. small buffers, corrupted data in Read, etc.
  • Separate header destination: if it's not null then it must be equal to current. Existing api could redirect to ptr and ptr + 4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant