Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webcord crashes at the installation on Windows 11 #476

Open
3 of 7 tasks
Uneccessary opened this issue Oct 15, 2023 · 3 comments
Open
3 of 7 tasks

Webcord crashes at the installation on Windows 11 #476

Uneccessary opened this issue Oct 15, 2023 · 3 comments
Assignees
Labels
status:wontfix This will not be worked on type:bug Something isn't working

Comments

@Uneccessary
Copy link

Acknowledgements

  • I have checked that there is no other issue describing the same or
    similar problem that I currently have, regardless if it has been
    closed or open.

  • This bug affects Discord website.

  • This issue is confirmed to be reproducible when WebCord is packaged
    on at least all three latest supported Electron major releases.

  • This issue is reproducible in Chrome, Chromium or any
    Chromium-based browser, e.g Brave or Edge (please write in
    Additional Context which browser you have used if it is neither
    Chrome nor unmodified Chromium).

  • There are no fixes done to master which resolves this issue.

  • My issue describes one of the unstable and/or not fully implemented
    features.

  • I have found a workaround to mitigate or temporarily fix this issue
    in affected releases (please write it in Additional context section
    below).

Operating System / Platform

🪟️ Windows

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

The latest which is used by Webcord

Application version

v.4.4.0 up to v4.5.0

Bug description

Webcord crashes on installation and don't finish to install correctly

Additional context

No response

@Uneccessary Uneccessary added the type:bug Something isn't working label Oct 15, 2023
@SpacingBat3
Copy link
Owner

SpacingBat3 commented Oct 15, 2023

TL;DR: Squirrel sucks.

This was discussed somewhere before. And in reality it doesn't crash, it just doesn't have any installation logic that Squirrel expects for it to have. And no, I don't know if I'll be handling it any time soon, I'm strongly against bundling the large chunk of the code for installation logic that's pretty much useless in other bundles than Squirrel or platforms. So most likely I'll ditch Squirrel for NSIS installer if I'll do ones as part of ReForged (or someone will do a high-quality maker before, either be it official or unofficial ones).

@SpacingBat3
Copy link
Owner

And in general WebCord should be installed automatically by Squirrel to %appdata%.

@SpacingBat3 SpacingBat3 added the status:wontfix This will not be worked on label Oct 15, 2023
@SpacingBat3
Copy link
Owner

Eventually, I could dig for some hook in Forge, maybe like preMake, that runs on packaged app (i.e. WebCord's transpiled code + Electron binary) and would either add or remove the Squirrel logic from the code based whenever currently Squirrel is being built or not, but this kind of hook should be run always before making any kind of distributable, so it can prepare the package correctly even when making different distributables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:wontfix This will not be worked on type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants