Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chat #8

Open
3 tasks
SpaceOgre opened this issue Dec 19, 2019 · 13 comments
Open
3 tasks

Add chat #8

SpaceOgre opened this issue Dec 19, 2019 · 13 comments
Labels
enhancement New feature or request

Comments

@SpaceOgre
Copy link
Owner

SpaceOgre commented Dec 19, 2019

The original creator tried to add chat years ago via iframe but said it lagged a lot because of flash. It might work much better now.

I think the fork for Tizien have chat so we can look and see if we can adapt it for this version.

Todo:

  • Add flyout to the left for chat.
  • Resize video when chat is visible
  • Test embed chat via iframe.
@SpaceOgre SpaceOgre added the enhancement New feature or request label Dec 19, 2019
@Fansh1ne
Copy link

I think with chat feature this app would be complete.

@SpaceOgre
Copy link
Owner Author

@Fansh1ne I have added a basic chat via embedding the chat in an iframe. This is the official way to do it according to Twitch. I'm not sure how good it will look on a TV or if it will work/lagg. Please test if you got the time.

It is in this branch: https://github.com/SpaceOgre/smarttv-twitch/tree/feature/chat

@Fansh1ne
Copy link

Fansh1ne commented Dec 23, 2019

I have tried the one from the link above and app is not working at all.

https://pixhost.to/show/268/130848828_img_20191223_222445.jpg

@SpaceOgre
Copy link
Owner Author

That's weird, I have not changed anything in the browsing part of the app 🤔
Is this how it looks from the start?

@Fansh1ne
Copy link

Fansh1ne commented Dec 23, 2019

Yes. First time I started the app it looked like this. Tried starting it a few more times, same thing. It is indeed weird.

@SpaceOgre
Copy link
Owner Author

I forgot to merge the username fixes from master to the chat branch. Did that now but could not get it to work but did not have time to test it with userid set.

If you are upp for it you can try the chat branch again.

Oh does the 3.9.2 version work for you? Just trying to locate what I messed up :/
This JavaScript thing on a TV with like zero debug is driving me a bit crazy...

@SpaceOgre
Copy link
Owner Author

I think I found the problem, I had written enableChat = true instead of enableChat: true in the config.js file. It is now fixed.

@Fansh1ne
Copy link

Syntax error :) 3.9.2 working fine (20-30sec delay is still present when comapred to pc-chrome-twitch website). I will test it today when I get some time.

@Fansh1ne
Copy link

I have just tried it. It works like regular no chat version of the app. So basically streams are loading but there is no chat. I looked for option somewhere (to enable/disable chat) and haven't seen one. Tried a few different streamers, same, no chat visible.

@SpaceOgre
Copy link
Owner Author

The chat should show in the choose quality panel on the right. To show it press enter or left arrow.

@Fansh1ne
Copy link

I checked there, only choose quality panel, no chat. Looks same just in regular 3.9.2 release.

@SpaceOgre
Copy link
Owner Author

Okay, as long as enableChat is set to true in config.js then it should show if it works.
I guess the browser/engine used by the TV might just not be able to handle the embedded stuff from Twich sadly.

The Tizien fork is using websockets and connecting to the irc channel directly. Will look at this and see if I can use the same implementation here.

@Fansh1ne
Copy link

Thanks for trying. If you need help, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants