Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album loading performance #40

Open
SoongNoonien opened this issue Aug 14, 2021 · 3 comments
Open

Album loading performance #40

SoongNoonien opened this issue Aug 14, 2021 · 3 comments

Comments

@SoongNoonien
Copy link
Owner

The album(-cover) loading performance is improvable. This issue is to provide a place for discussion on that topic. It has been extracted from #39.

@SoongNoonien
Copy link
Owner Author

The newest commit (4245b40) changes the album loading a bit. Initial GUI blocks in combination with large artists (many albums) should now be gone. I also separated the fetching/locating of the covers from the actual loading of the albums which decreases the initial time needed to display the albums without their covers. Sadly the overall time did not really decrease. The complete procedure is now run in a separate thread using python's threading module but this should manly increase the reliability and not the performance.

@dgcampea It would be really nice if you could test these changes.

@dgcampea
Copy link
Contributor

dgcampea commented Sep 11, 2021

I can confirm that 4245b40 in general improves the responsiveness of the GUI (previously it would stutter when changing between album artists).

The listing of "all artists" still takes a while but the times seem to have gone down as well.

@dgcampea
Copy link
Contributor

dgcampea commented Oct 4, 2021

Might be worth a look (haven't looked too deeply into it yet):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants