Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin and Erlang version mapping? #17

Open
joshOfAllTrades-zz opened this issue Jul 13, 2016 · 7 comments
Open

Plugin and Erlang version mapping? #17

joshOfAllTrades-zz opened this issue Jul 13, 2016 · 7 comments

Comments

@joshOfAllTrades-zz
Copy link

Is there a mapping of which versions of Erlang are supported by which versions of this plugin? I'm encountering issues analyzing Erlang 18.3.

@kalidasya
Copy link
Contributor

Hi,

I think erlang is supported up to 17, if you create a small reproduction with you issues I can try to fix it. or you can create a MR with the fix

@joshOfAllTrades-zz
Copy link
Author

joshOfAllTrades-zz commented Jul 18, 2016

mapify_services( Hostname, Services ) -> 
[ 
  #{ 
    id  => ServiceId,
    name => bin( Name ), 
    address => bin( Hostname ), 
    port => Port, 
    type => bin( Type )
  } 
  || { ServiceId, Name, Port, Type } <- Services 
].

The plugin doesn't like the => operator.

@joshOfAllTrades-zz
Copy link
Author

get_apis( Services ) when is_list( Services ) -> 
  F = fun( Service, Acc ) when is_map( Service ) -> 
    #{ "vendorservice" := VendorService, "apis" := Apis } = Service, 
    BinApis = [ bin( Api ) || Api <- Apis ], 
    [{VendorService, BinApis} | Acc] 
  end, 
  maps:from_list( foldl( F, [], Services ) ).

The plugin doesn't like the := operator.

@kalidasya
Copy link
Contributor

@joshOfAllTrades map support is there and it seems to work on master, can you build master and give it a try?

@kalidasya
Copy link
Contributor

kalidasya commented Jul 18, 2016

also the example with => seem to work, if it is failing with master for you, can you send me the full exception?

kalidasya added a commit that referenced this issue Jul 18, 2016
@kalidasya
Copy link
Contributor

@joshOfAllTrades any result with the snapshot? is it working on your codebase?

@FrankGiesecke
Copy link

Does the issue #24 depends on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants