Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit webook address space? #1163

Open
Yshayy opened this issue Aug 8, 2019 · 0 comments
Open

Limit webook address space? #1163

Yshayy opened this issue Aug 8, 2019 · 0 comments

Comments

@Yshayy
Copy link
Contributor

Yshayy commented Aug 8, 2019

We should consider adding some filtering to disallow creating a hook that invokes a local/internal http/s endpoint:
https://docs.gitlab.com/ee/security/webhooks.html
Also, might worth adding a Tweek internal configuration for only allowing https hooks. (or better, probably the default should be https only, and http can be enabled for local testing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant