Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yahoo OAuth2 has been deprecated #124

Open
curtisgibby opened this issue Jul 30, 2020 · 4 comments
Open

Yahoo OAuth2 has been deprecated #124

curtisgibby opened this issue Jul 30, 2020 · 4 comments

Comments

@curtisgibby
Copy link

Issue

Yahoo! has EOL'd their OAuth2 ("Social Directory") API, and is encouraging developers to adopt an OpenID Connect pattern for their user authentication flow.

My env

PHP: 7.2

Library: ADmad cakephp-social-auth

Provider: Yahoo (OAuth2)

Provider options:

'yahoo' => [
    'applicationId' => Configure::read('Yahoo.app_id'),
    'applicationSecret' => Configure::read('Yahoo.app_secret'),
]

I'll try to figure out how to adapt the existing Google OpenID Connect provider to create a version for Yahoo.

@curtisgibby
Copy link
Author

I spent hours last night trying to get the OpenID Connect version of Yahoo's implementation working correctly, but was stymied by decoding the id_token that they return. They're giving it back with an algorithm of ES256, but the SocialConnect JWX library doesn't support this algo. @ovr can you tell me why this support was removed?

Is there a way to tell Yahoo "these are the decoding methods that we support", so that it gives us back the token in, say, RS256 instead?

@ovr
Copy link
Member

ovr commented Aug 1, 2020

Hey!

hey're giving it back with an algorithm of ES256, but the SocialConnect JWX library doesn't support this algo.

A lot of time passed, I am trying to remember and possible ES was disabled, because I was not able to implement ES keys encoding... (maybe)

This moment,

https://github.com/SocialConnect/jwx/blob/master/tests/JWTTest.php#L228

Who knows 😸

@ovr
Copy link
Member

ovr commented Aug 1, 2020

Added ES256/384/512 support back with tests on real EC keys.

Released as 1.2.0

Should works I think.

@ovr
Copy link
Member

ovr commented Sep 20, 2020

ping @curtisgibby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants