Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS app crashes after map zooms in #51

Open
abannert opened this issue Aug 7, 2016 · 6 comments
Open

iOS app crashes after map zooms in #51

abannert opened this issue Aug 7, 2016 · 6 comments

Comments

@abannert
Copy link
Collaborator

abannert commented Aug 7, 2016

The iOS app is crashing. It starts up and shows the map, asks for location, starts to zoom to current location and then crashes. I'm guessing it's a parse error in the response from the server, now that the yelp data is missing.

@jwieringa
Copy link
Collaborator

jwieringa commented Aug 8, 2016

@abannert I'll check out the API today to check the regression in the API.

@jwieringa
Copy link
Collaborator

I think that this might be from from a missing distance key in the returned JSON.

"retailer": {
  "id": 24946,
  "name": "7-Eleven Inc F 10764A",
  "lat": "38.798351",
  "lon": "-77.049843",
  "street": "800 Franklin St",
  "city": "Alexandria",
  "state": "VA",
  "zip": "22314",
  "zip_plus_four": "4106",
  "created_at": "2016-08-09T06:35:22.750Z",
  "updated_at": "2016-08-09T06:35:22.750Z"
}

My understanding is that SnapRetailer is expecting distance to be in the response. https://github.com/SnapFresh/SnapFresh/blob/master/iOS/SnapFresh/Model/SnapRetailer.swift#L42 Looking into why distance isn't there.

@jwieringa
Copy link
Collaborator

Text renders fine http://snapfresh.org/retailers/nearaddy.txt?address=22314

screen shot 2016-08-09 at 3 28 02 am

I've reviewed the changes to /retailers/nearaddy.json and it seems that recent updates were careful to move/change the code instead preferring adding a new endpoint /retailers.json (which also has the same bug).

@jwieringa
Copy link
Collaborator

I've added a test which show the regression #52

Looks I missed a test for the distance key and have added it along with the ability to execute tests in a container.

@jwieringa
Copy link
Collaborator

I've add a fix for one endpoint in #53, the retailers/nearaddy.json still needs debugging.

@jwieringa
Copy link
Collaborator

#53 now includes a fix for retailers/nearaddy.json. The fix should now be ready to deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants