[Tracker] Fix inline script execution on Checkout page according to CSP restrictions #3277
+70
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahonc
force-pushed
the
3270-elasticsuite-tracker-content-security-policy-2.11-fix
branch
from
67fa823
to
da235f7
Compare
vahonc
changed the title
hostep
reviewed
Jun 4, 2024
| beaconUrl: '{$beaconUrl}', | ||
| telemetryUrl: '{$telemetryUrl}', | ||
| telemetryEnabled: '{$telemetryEnabled}', | ||
| sessionConfig: '{$sessionConfig}' |
There was a problem hiding this comment.
@vahonc: I believe there is a bug introduced on this line, the single quotes should not be needed around {$sessionConfig}. If the json data contains a single quote, this will break. In the old code, there also weren't single quotes surrounding this value.
There was a problem hiding this comment.
My bad, it looks like @romainruaud already fixed this shortly after merging this, in daff073, thanks guys!
There was a problem hiding this comment.
Yes correct @hostep :)
There was a problem hiding this comment.
Sorry guys, it's just a typo, my bad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the CSP updates:
now an inline scripts should be wrapped using
$secureRenderervariable in the.phtmltemplates, but for some reason this blocks the work of our Tracker script on Checkout page.See more: