Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ChargingBench #4184

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix ChargingBench #4184

wants to merge 3 commits into from

Conversation

Intybyte
Copy link

@Intybyte Intybyte commented May 3, 2024 •
edited

Description

Making ChargingBench rechargeable only ItemStacks with 1 items

Proposed changes

By adding this feature addon makers can make heir own Rechargeable any item they want and not be limited to tools

Related Issues (if applicable)

Resolves #4183

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@Intybyte
Fix ChargingBench
2fd2cea 
- ChargingBench can now only recharge ItemStacks with 1 item.
@Intybyte Intybyte requested a review from a team as a code owner May 3, 2024 17:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@Intybyte @J3fftw1
Update src/main/java/io/github/thebusybiscuit/slimefun4/implementatio…
0c397a7 
…n/items/electric/machines/ChargingBench.java

Co-authored-by: J3fftw <44972470+J3fftw1@users.noreply.github.com>
@JustAHuman-xD JustAHuman-xD added the ✨ Fix This Pull Request fixes an issue. label May 4, 2024
J3fftw1
J3fftw1 previously approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@J3fftw1 J3fftw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JustAHuman-xD
Copy link
Contributor

I did not want to dismiss the review aaaa

@github-actions GitHub Actions
Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: cf0a9e8

https://preview-builds.walshy.dev/download/Slimefun/4184/cf0a9e8e

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

JustAHuman-xD
JustAHuman-xD approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustAHuman-xD JustAHuman-xD JustAHuman-xD approved these changes

@J3fftw1 J3fftw1 J3fftw1 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChargingBench can recharge muliple stackable items.
3 participants
@Intybyte @JustAHuman-xD @J3fftw1