Added McMMO anvil fix #4182
Open
Added McMMO anvil fix #4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now you cannot repair or use sf materials to repair other items - Translation key mcmmo-repair should be added
|
Pro Tip!
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀 |
J3fftw1
requested changes
May 4, 2024
src/main/java/io/github/thebusybiscuit/slimefun4/integrations/McMMOIntegration.java
Outdated
Show resolved
Hide resolved
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4182/34d861b5
|
…McMMOIntegration.java Co-authored-by: J3fftw <44972470+J3fftw1@users.noreply.github.com>
J3fftw1
approved these changes
May 10, 2024
JustAHuman-xD
approved these changes
May 30, 2024
JustAHuman-xD
added
the
🎯 Needs testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing a bug where having mcmmo would allow you to repair for instance a gold chestplate with 4k gold, and then dismantling it for normal gold, or using lead to repair an iron sword. You can use slimefun items to repair vanilla items and use items to repair Slimefun items
Proposed changes
Added and event listener for the repair event.
Add a translation key for the error mcmmo.anvil-repair
Related Issues (if applicable)
Resolves #4181
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values