Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AureliumSkills incompatibility with potion recipes due to editing modifiers #4014

Open
4 tasks done
Skizzles opened this issue Nov 5, 2023 · 1 comment
Open
4 tasks done
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team.

Comments

@Skizzles
Copy link
Contributor

Skizzles commented Nov 5, 2023

❗ Checklist

  • I am using the official english version of Slimefun and did not modify the jar.
  • I am using an up to date "DEV" (not "RC") version of Slimefun.
  • I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • I searched for similar open issues and could not find an existing bug report on this.

📍 Description

Aurelium Skills boosts the durations and modifiers of potions which makes some recipes like Magical Zombie Pills uncraftable. Ideally it would be nice if Slimefun didnt check for the exact duration and such and just that it was a weakness potion.

📑 Reproduction Steps

Install Aurelium Skills
Level ur Alchemy Skill
Brew Potions
Attempt to craft with a modified duration potion.

💡 Expected Behavior

Ideally I feel that with plugins modifying potions, slimefun just accepting that its a weakness potion or something would be nice and not checking for exact NBT.

📷 Screenshots / Videos

image
image

📜 Server Log

N/A No error messages are found

📂 /error-reports/ folder

N/A

💻 Server Software

Purpur

🎮 Minecraft Version

1.20.x

⭐ Slimefun version

https://screenshots.skizzles.me/wAnA3/maHinIlO37.png

🧭 Other plugins

AureliumSkills

@Skizzles Skizzles added 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. 🐞 Bug Report A bug that needs to be fixed. labels Nov 5, 2023
@J3fftw1
Copy link
Member

J3fftw1 commented Nov 5, 2023

This should be fixed with the recipe rewrite, this is the same reason elytras dont work when damaged or any other tool.

@J3fftw1 J3fftw1 added 🧨 Confirmed Bug This bug has been confirmed by our team. and removed 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. labels Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team.
Projects
None yet
Development

No branches or pull requests

2 participants