Soulbound items disappear when restarting the server mid-deathscreen

[N1kyZ]

❗ Checklist

• I am using the official english version of Slimefun and did not modify the jar.
• I am using an up to date "DEV" (not "RC") version of Slimefun.
• I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
• I searched for similar open issues and could not find an existing bug report on this.

📍 Description

When a player dies with Soulbound items. After restarting the server, the items disappear

📑 Reproduction Steps

1. Have items with Soulbound
2. Then you die
3. Restart the server
4. Join the server
5. Checks if Soulbound items are there

💡 Expected Behavior

Soulbound items do not disappear

📷 Screenshots / Videos

Before restarting

After restart

📜 Server Log

no errors to log

📂 /error-reports/ folder

no errors to folder

💻 Server Software

Paper

🎮 Minecraft Version

1.17.x

⭐ Slimefun version

Paper git-Paper-411 (MC: 1.17.1)
Slimefun DEV - 1043 (git 4bfc4f0)
Metrics-Module #28
Java 17

🧭 Other plugins

No response

[Boomer-1]

please provide your full plugin list and if you have any datapacks installed

[N1kyZ]

OBS: Have to restart server on death screen

no data pack installed
plugins:

[Boomer-1]

over many repeated attempts i cannot duplicate this with 1.17.1 and dev 1043

[Boomer-1]

what mods are you using?

[N1kyZ]

no mod

[Boomer-1]

well, you have at least one based on the picture you provided of your inventory. something you've installed, in the server or the client is interfering. without all the info we can't help

[N1kyZ]

I managed to fix my OBS, maybe this will help

2023-02-20-23-17-31_ydqhLUo4.mp4

2023-02-20.23-19-22.mp4

[N1kyZ]

and the server was created from scratch to test this, just with the addition of slimefun

[Boomer-1]

you have a mod installed. numbers in your inventory is not vanilla

[N1kyZ]

texturepack

[Boomer-1]

with the exact same server, minecraft version and slimefun version i cannot recreate it. I've tried netherite armor, diamond armor and it stays everytime. try removing the pack and do it again

[Boomer-1]

ok. i think i figured it out. you're shutting your server down before the player clicks respawn. that's the only way i've been able to do it. so in the extreme possibility that the player dies in that millisecond, and they can't click respawn it disappears. in that brief moment between death and the server restart, the event cant fire. iirc, it fires on the click of respawn. because the data can't be saved thru a restart. not sure if there's a fix to that or not. Dev's will have to look into it.

[Boomer-1]

So whomever wants to look into this, the key here is the server shuts down before the player clicks respawn. that key moment is the issue

[J3fftw1]

@Boomer-1 i would assume this also happens when the player disconnects and joins back after he died?

[RayBytes]

ok. i think i figured it out. you're shutting your server down before the player clicks respawn. that's the only way i've been able to do it. so in the extreme possibility that the player dies in that millisecond, and they can't click respawn it disappears. in that brief moment between death and the server restart, the event cant fire. iirc, it fires on the click of respawn. because the data can't be saved thru a restart. not sure if there's a fix to that or not. Dev's will have to look into it.

what about storing it as NBT on the player? in the .dat

[SrMonsterYT]

this is also happening on my server, players are reporting this