Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not properly shutting down async threads nag (paper) #3560

Open
4 tasks done
walksanatora opened this issue May 17, 2022 · 3 comments
Open
4 tasks done

not properly shutting down async threads nag (paper) #3560

walksanatora opened this issue May 17, 2022 · 3 comments
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team.

Comments

@walksanatora
Copy link

❗ Checklist

  • I am using the official english version of Slimefun and did not modify the jar.
  • I am using an up to date "DEV" (not "RC") version of Slimefun.
  • I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • I searched for similar open issues and could not find an existing bug report on this.

📍 Description

when i stop my slimefun server it pops up saying [09:02:25 ERROR]: Nag author: 'The Slimefun 4 Community' of 'Slimefun' about the following: This plugin is not properly shutting down its async tasks when it is being shut down. This task may throw errors during the final shutdown logs and might not complete before process dies

📑 Reproduction Steps

  1. start a server with slimefun
  2. wait for server to load
  3. run the stop command in console
  4. paper nag appears

💡 Expected Behavior

i expect there to be no nag

📷 Screenshots / Videos

No response

📜 Server Log

https://pastebin.com/thd3NVcK

📂 /error-reports/ folder

No response

💻 Server Software

Paper

🎮 Minecraft Version

1.18.x

⭐ Slimefun version

vDEV - 1014 (git f431aa6)

🧭 Other plugins

No response

@walksanatora walksanatora added 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. 🐞 Bug Report A bug that needs to be fixed. labels May 17, 2022
@JustAHuman-xD
Copy link
Contributor

Is this issue still occurring? I haven't noticed it on my test servers.

@variananora
Copy link
Member

Is this issue still occurring? I haven't noticed it on my test servers.

sometimes it does, sometimes it doesnt. but havent seen it in a while tho.
the easy way to replicate this to just start a server and typing stop immediately, but i doesnt do it 100% of the time also...
i think this is more like an edge cases tho.

@JustAHuman-xD
Copy link
Contributor

Ah gotcha

@variananora variananora removed the 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. label Jul 4, 2023
@J3fftw1 J3fftw1 added the 🧨 Confirmed Bug This bug has been confirmed by our team. label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Report A bug that needs to be fixed. 🧨 Confirmed Bug This bug has been confirmed by our team.
Projects
None yet
Development

No branches or pull requests

4 participants