Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Java not killed after exiting app #989

Open
i0ntempest opened this issue Apr 14, 2024 · 8 comments · May be fixed by #1034
Open

macOS: Java not killed after exiting app #989

i0ntempest opened this issue Apr 14, 2024 · 8 comments · May be fixed by #1034
Labels
Area: Server Related to the server OS: macOS Operating system: macOS Type: Bug Something isn't working

Comments

@i0ntempest
Copy link

Running 0.11.0. After opening and quitting the server app, execute ps -ef | grep java in terminal:

  501  9051     1   0  2:08PM ??         0:03.52 /usr/bin/java -Xmx512M -jar slimevr.jar run
  501  9092  6866   0  2:08PM ttys002    0:00.00 grep --color=auto java

You may see that the java process was not killed. This causes the app to complain "startup error: required ports are busy" on the next run.

@ImUrX
Copy link
Member

ImUrX commented Apr 14, 2024

can you please show server and gui logs

@ImUrX ImUrX added Type: Bug Something isn't working OS: macOS Operating system: macOS Area: Server Related to the server labels Apr 14, 2024
@i0ntempest
Copy link
Author

Where do I get those logs?

@ImUrX
Copy link
Member

ImUrX commented May 7, 2024

sorry forgot to answer ~/Library/Logs/dev.slimevr.SlimeVR

@i0ntempest
Copy link
Author

log_last_0.log
slimevr_rCURRENT.log
This was collected after after I killed java after quitting the app.

@ImUrX
Copy link
Member

ImUrX commented May 15, 2024

uhm, did you ever close the app? because GUI logs never say it closed...

do you have tray enabled?

@ImUrX
Copy link
Member

ImUrX commented May 15, 2024

probably related to tauri-apps/tauri#9198, i suspect that Command+Q or Quit is passing as a kill command more than an ExitRequested in Tauri

@i0ntempest
Copy link
Author

That's exactly what I just found out. It handles a click on the X button just fine but not Cmd+Q.

@ImUrX
Copy link
Member

ImUrX commented May 15, 2024

We need to intercept RunEvent::Exit then

@ImUrX ImUrX linked a pull request May 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Server Related to the server OS: macOS Operating system: macOS Type: Bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants