Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to Okio Buffer instead of using ByteBuffer #1002

Open
ImUrX opened this issue Apr 21, 2024 · 0 comments
Open

migrate to Okio Buffer instead of using ByteBuffer #1002

ImUrX opened this issue Apr 21, 2024 · 0 comments
Labels
Area: Server Related to the server Difficulty: Large refactor Requires modifying large sections of the codebase Type: Enhancement Adds or improves a feature

Comments

@ImUrX
Copy link
Member

ImUrX commented Apr 21, 2024

Using Buffer from Okio will help in the future if we want to do a full Kotlin migration, and it helps readability by not using the ByteBuffer#getInt() (which in kotlin looks like buffer.int) and instead it uses Buffer#readInt()
@ImUrX ImUrX added Difficulty: Large refactor Requires modifying large sections of the codebase Type: Enhancement Adds or improves a feature Area: Server Related to the server labels Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Server Related to the server Difficulty: Large refactor Requires modifying large sections of the codebase Type: Enhancement Adds or improves a feature
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ImUrX