-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.0] Installer needs General language file? #8221
Comments
Well, that's an easy thing to fix. |
After fixing it, my installer times out in step 2 |
Without your pull request I get the following (and the db is created):
|
Yes, that is one of the errors fixed by the PR. |
Yup, times out with the PR on step 2. I don’t have errors or warnings. |
Odd. I can't test at the moment, but could you try reverting the change to the user agent constant (the only other change in install.php) and then test again? |
Reverted the line, no more time out but two issues:
|
Latest commits to #8204 should fix those. |
Got a few more
|
I've added another commit to #8204 to fix those, too. |
Another round
|
I've amended the commit to fix those as well |
I'm afraid they keep coming. Might need to set all of the $modSettings keys to a default value instead? |
The one that errored out (no warning), was this one: |
Alright, I've backed up and taken another approach. The initial error that you are encountering on line 1495 of install.php will still happen, but now it will simply die rather than trying to load all the usual stuff needed to display a fatal error message in a theme template. Solving that initial error can be the subject of a separate PR. |
Actually, I've decided to move the fixes for this installer issue into their own PR (#8223) rather than tacking them onto the fixes for the upgrader. Please test that PR to see if it solves the issue for you, @DiegoAndresCortes. You will most likely still run into the issue on line 1495 of install.php, but we'll need to deal with that once it can be isolated from the cascade of other problems that followed it. |
I’ll test later today |
The installer uses formatMessage for
$txt['install_welcome_desc']
but this method will fail when it attempts to get $txt['lang_locale'] because the general language file is not loaded in the installer.The text was updated successfully, but these errors were encountered: