Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.1]: Notication emails for reply not sent if user also subscribe for the board #8180

Open
BrickOzp opened this issue Apr 25, 2024 · 2 comments
Open

[2.1]: Notication emails for reply not sent if user also subscribe for the board #8180

BrickOzp opened this issue Apr 25, 2024 · 2 comments
Labels
Not Verified

Comments

@BrickOzp
Copy link
Contributor

Basic Information

If a user subscribes for notification of replies to a topic and also for new topics in the same board, notifications are not sent for the first subscription.

Steps to reproduce

  1. Subscribe to a topic with email notifications
  2. Subscribe to the board where the first topic is located with email notifications
  3. With another user, post a reply to the topic in step 1

Expected result

Email is sent to the users subscribing to the topic.

Actual result

No email is sent to those who subscribe both to the topic and the board.

Version/Git revision

2.1.4

Database Engine

All

Database Version

10.6.17-MariaDB-cll-lve

PHP Version

7.4

Logs

The problem seems to be that the database query returns two records if the user subscribes to both the topic and the board. Only the last row will be used.

Additional Information

No response
BrickOzp added a commit to BrickOzp/SMF2.1 that referenced this issue Apr 25, 2024
@BrickOzp
Fix topic notifications if user subscribe to both topic and board
4277718 
Combine the topic and board record into one.

Fixes: SimpleMachines#8180

Signed-off-by: Oscar Rydhé <oscar.rydhe@gmail.com>
@BrickOzp BrickOzp mentioned this issue Apr 25, 2024
Merged
@sbulen
Copy link
Contributor

sbulen commented Apr 25, 2024

This is a dupe:
#7680

Fix:
#7691

@BrickOzp
Copy link
Contributor Author

It seems that fix was included in 2.1.4 but the issue still exists for 2.1.4

@BrickOzp BrickOzp reopened this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Not Verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Sesquipedalian @BrickOzp @sbulen