-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.1]: Themes can't customize the CSS for SCEditor, take two #8135
Comments
ref #6837 This seems to be by design, albeit a weird one Lines 1524 to 1533 in 9ebd5b0
|
I appreciate the checking into it. The logic makes sense; the intended mitigation apparently just didn't turn out to be easy and obvious enough. ;-) The only idea I have to help with that, past putting in more red text somewhere that people are going to ignore, is that perhaps there could be a dummy jquery.sceditor.theme.css file bundled with Curve2. I use dev tools extensively, and if it called that file in the list, there's a fair chance I would have seen it and the explanation inside of it. As it is, I assumed this was a bug, but didn't investigate deeper than the surface behaviour. Of course, while this throws devs a bone, it's at the cost of 1k bandwidth for the initial load, multiplied over millions of uses. If you decided it isn't worth the tradeoff, I definitely understand. My issue seems resolved now, anyway. |
The naming of the files is weird, they don't do what you think they should be doing by their names... It could definitely use some cleaning/clearing up. But you can do everything you want to do today... From the forum: https://www.simplemachines.org/community/index.php?msg=4157739
So... Yes, it will always load jquery.sceditor.css. If you want to override that, you can put the overrides you want in jquery.sceditor.theme.css. That's how it works today. I believe the idea was you only need to put .css in there for the parts you want to override. Why the WYSIWIG file was named "default" is anyone's guess. |
I came up with this in my themes, for the dark mode and variants issue: |
Because in the upstream repo, it is https://github.com/samclarke/SCEditor/tree/master/src/themes |
We really need to move this issue to the Discussions tab. |
Basic Information
When using a custom theme, the jquery.sceditor.css file is loaded from the default theme even when the custom theme has its own file.
Steps to reproduce
Expected result
The theme should load its own jquery.sceditor.css file.
Actual result
It loads from the default theme (Curve2).
Version/Git revision
2.1.4
Database Engine
All
Database Version
No response
PHP Version
8.1.27
Logs
No response
Additional Information
This is similar to issue #5601, which concerned jquery.sceditor.default.css, and I expect it should have a similar fix.
The text was updated successfully, but these errors were encountered: