Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1, 3.0]: Wrong position for $context['error_code'] in template #8049

Open
dragomano opened this issue Jan 27, 2024 · 3 comments
Open

[2.1, 3.0]: Wrong position for $context['error_code'] in template #8049

dragomano opened this issue Jan 27, 2024 · 3 comments
Assignees
Milestone

Comments

@dragomano
Copy link
Contributor

Basic Information

Errors.template.php, function template_fatal_error:

<div ', $context['error_code'], 'class="padding">

Result HTML (for example, on 404 error):

<div 404class="padding">

As a result, the padding class is not recognized and does not work.

Steps to reproduce

  1. Open non-exist action
  2. Open browser's devtools and select the message block

Expected result

<div class="padding">

or maybe

<div class="padding error_404">

Actual result

<div 404class="padding">

Version/Git revision

2.1.4, 3.0 Alpha 1

Database Engine

MySQL

Database Version

MariaDB-10.6.11

PHP Version

8.0.30

Logs

No response

Additional Information

No response

@jdarwood007
Copy link
Member

@DiegoAndresCortes and @TwitchisMental, Can you add this to the theme PR (#7933)?

@jdarwood007 jdarwood007 added this to the 3.0 Alpha 4 milestone Jan 28, 2024
@DiegoAndresCortes
Copy link
Contributor

Can you assign it to me I'll check it in a few weeks

@DiegoAndresCortes
Copy link
Contributor

Minor version is inverted in title of the issue btw

@jdarwood007 jdarwood007 changed the title [2.0, 3.1]: Wrong position for $context['error_code'] in template [2.1, 3.0]: Wrong position for $context['error_code'] in template Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants