Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0]: Avatar changing #8023

Closed
jdarwood007 opened this issue Jan 16, 2024 · 4 comments
Closed

[3.0]: Avatar changing #8023

jdarwood007 opened this issue Jan 16, 2024 · 4 comments
Labels
Milestone

Comments

@jdarwood007
Copy link
Member

Basic Information

When trying to use a SVG for a avatar, a fatal PHP error occurs and the avatar is not saved

Steps to reproduce

  1. Go to Forum Profile
  2. Choose an external image
  3. Enter: https://www.php.net/images/logos/php-logo-white.svg

Expected result

Forum Profile is saved and avatar changed

Actual result

Fatal PHP error

Version/Git revision

3054fc2

Database Engine

All

Database Version

N/A

PHP Version

8.1.24

Logs

No response

Additional Information

@Sesquipedalian I'm seeing multiple avatar-related issues. Not just this one, but its the one I'm not certain on how we intend to fix, since we are passing things through Image handler and then trying to use $image->type, which is not defined.

@jdarwood007 jdarwood007 changed the title [3.0]: Unable to use SVG for profile image [3.0]: Avatar changing Jan 16, 2024
@jdarwood007
Copy link
Member Author

Changing the title here. I found a few more problems

  • Can not use a webp image.
  • When you do set an image, the preview seems to be 'sticky' for that page load and does not refresh until the next page load
  • The avatar does not detect which type was set correctly.

@frandominguezl
Copy link
Member

I couldn't reproduce with the latest build

SVG test:
imagen

Webp test:
imagen
Test image: https://tmpr.s3.eu-central-1.amazonaws.com/assets/imgs/webp-test.webp

@DiegoAndresCortes
Copy link
Contributor

Maybe #8226 fixed this too?

@Sesquipedalian
Copy link
Member

Maybe #8226 fixed this too?

Maybe. At any rate, it seems that we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants