Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SPAuthenticator & signingIn to protocol of SPAuthenticatorDelegate #562

Open
lukegeiger opened this issue Dec 7, 2016 · 1 comment

Comments

@lukegeiger
Copy link

I am using a custom authentication flow in my app, and I do not want to use SPAuthenticaionViewController. However when I subscribe to SPAuthenticatorDelegate I am forced to add the following properties to my view controller.

@Property (nonatomic) SPAuthenticator *authenticator;
@Property (nonatomic, assign, readwrite) BOOL signingIn;

Shouldn't these just be some required methods to implement in an a authentication protocol?

@jleandroperez
Copy link
Contributor

Hello there @lukegeiger!

Sounds accurate: those two properties would be probably better part of a protocol. Back in the day, this was implemented to be consumed by Simplenote iOS.

You can check out it's current implementation here and here. Long story short, the customized login screen inherits from SPAuthenticationViewController, and tweaks few things around.

I'm sorry to say we can't really provide a schedule of when we'd be able to update / enhance the SPAuthenticatorDelegate protocol, since this is a bit of a low priority at this moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants