Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the customizability of authentication screens #162

Open
8 tasks
mikejohnstn opened this issue Nov 1, 2013 · 4 comments
Open
8 tasks

Improve the customizability of authentication screens #162

mikejohnstn opened this issue Nov 1, 2013 · 4 comments

Comments

@mikejohnstn
Copy link
Contributor

  • Terms of service (TOS) text is not localized
  • Set a custom TOS URL (maybe using localization?)
  • Option to make the displaying of the TOS link optional
  • Option to add the Forget password link
  • Option to set the color of the Navigation controller (when authenticationOptional is active)
  • Option to change the sign-in button colors
  • Option to set the font type & size for the texts (especially for the UITextFields)
  • The logo should not be hidden on an iPad, there is enough space to show all content

From #156 (comment)

@mikejohnstn
Copy link
Contributor Author

Related: #153

@jleandroperez
Copy link
Contributor

  • Restrict the ability for users to sign up and only allow login.

Ref Issue #237

@danielr
Copy link

danielr commented Jun 17, 2014

Just a thought: Rather than requiring to subclass SPAuthenticationViewController, you could introduce a protocol that includes authenticator and signingIn as required properties and to which any custom authentication view controller must conform to. So, basically the authentication view controller type would be something like UIViewController<SPAuthenticationUISupport>. A quick look at the code didn't reveal any further dependencies to SPAuthenticationViewController other than the two properties mentioned above.

This would allow to "start fresh", and thus also eliminate the risk of having weird and hard-to-debug side-effects caused by some superclass method (after all, SPAuthenticationViewController is quite a heavy view controller and does not seem to be specifically designed for safe subclassing).

@jleandroperez
Copy link
Contributor

I agree, we should decouple the backend interaction from the SPAuthenticationViewController class, and offer a mechanism to implement authentication by means of a protocol. That would allow 3rd party apps to implement auth in (any imaginable) way.

Perhaps that could even allow you to tap into the new TouchID API, and feed the fingerprint-token as the user password.

Thanks for your suggestion @danielr!

@jleandroperez jleandroperez modified the milestone: v0.7.1 Sep 9, 2014
@jleandroperez jleandroperez modified the milestone: v0.7.5 Nov 20, 2014
@jleandroperez jleandroperez modified the milestones: v0.7.5, v0.7.6 Nov 28, 2014
@jleandroperez jleandroperez modified the milestones: v0.7.6, v0.7.7 Jan 6, 2015
@jleandroperez jleandroperez modified the milestones: v0.7.7, v0.7.8, v0.7.9 Feb 4, 2015
@jleandroperez jleandroperez removed this from the v0.8.0 milestone May 10, 2015
@jleandroperez jleandroperez modified the milestones: v0.8.1, v0.8.2 Jun 8, 2015
@jleandroperez jleandroperez modified the milestones: v0.8.2, v0.8.3, v0.8.4 Sep 1, 2015
@jleandroperez jleandroperez modified the milestones: v0.8.4, v0.8.5, v0.8.6, v0.8.7 Sep 16, 2015
@jleandroperez jleandroperez modified the milestones: v0.8.7, v0.9.0 Oct 23, 2015
@jleandroperez jleandroperez removed this from the v0.9.0 milestone Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants