Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up how JSON parameters are processed and used #88

Open
ktbolt opened this issue Dec 12, 2023 · 0 comments
Open

Clean up how JSON parameters are processed and used #88

ktbolt opened this issue Dec 12, 2023 · 0 comments
Assignees
@ktbolt
Labels
enhancement New feature or request

Comments

@ktbolt
Copy link
Contributor

ktbolt commented Dec 12, 2023

The current implementation of how JSON parameters are processed and used is not very clean

  • lots of string literals all over the place
  • essentially procedural
  • awkward error checking
  • parameter literals used in Block constructors

Adding new parameters requires modifying functions in SimulationParameters.cpp and sometimes Block derived class files.

Parameters should really be encapsulated in classes so you know where they are defined , how they are related, etc.
@ktbolt ktbolt added the enhancement New feature or request label Dec 12, 2023
@ktbolt ktbolt self-assigned this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktbolt ktbolt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ktbolt