Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user-provided dependencies #60

Open
burgreen opened this issue Nov 2, 2023 · 2 comments
Open

Allow user-provided dependencies #60

burgreen opened this issue Nov 2, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@burgreen
Copy link

burgreen commented Nov 2, 2023

Thanks you for sharing this software!

Do any of your test cases replicate the P-V curve of a cardiac cycle?

I would suggest modifying your CMakeLists.txt to not require forced downloads of Eigen and the other 3 dependencies. If users have those packages already installed on their machines, let them supply the CMAKE_PREFIX_PATH and your CMakeLists.txt perform a find_package( xxx, REQUIRED) to locate the info.

@burgreen
Copy link
Author

burgreen commented Nov 2, 2023

Found what I was seeking in your ClosedLoopHeartPulmonary class along with the paper reference!

@burgreen burgreen closed this as completed Nov 2, 2023
@mrp089
Copy link
Member

mrp089 commented Nov 20, 2023

Thank you, @burgreen! It's a good idea to have a flag for user-provided dependencies.

@mrp089 mrp089 reopened this Nov 20, 2023
@mrp089 mrp089 added the enhancement New feature or request label Nov 20, 2023
@mrp089 mrp089 changed the title Really nice software! Allow user-provided dependencies Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants