Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile from source on CentOS with gcc10 #109

Open
caseyfleeter opened this issue Jul 15, 2022 · 2 comments
Open

Can't compile from source on CentOS with gcc10 #109

caseyfleeter opened this issue Jul 15, 2022 · 2 comments
Assignees

Comments

@caseyfleeter
Copy link

When compiling from source on CentOS 7 (Stanford's Sherlock cluster), gcc9 compilers must be used. This is okay for now, but in the future they may remove support for gcc9. There is an error using gcc10 compilers which seems to be due to a change in Fortran variable assignment error handling.

The change log for gcc10 (https://gcc.gnu.org/gcc-10/changes.html) in the Fortran section, third bullet, says: "Mismatches between actual and dummy argument lists in a single file are now rejected with an error. Use the new option -fallow-argument-mismatch to turn these errors into warnings; this option is implied with -std=legacy. -Wargument-mismatch has been removed."

It might be good to add the new option into the MakeFile so we can compile using gcc10 in the future. Thanks!

@ktbolt
Copy link
Contributor

ktbolt commented Jul 15, 2022

@caseyfleeter I ran into this problem a while back on MacOS (see #32) and added the -std=legacy option to the CMake files. I can add that for GNU compilers in general. Why do you use make rather than cmake to build the solver?

A better solution is to fix the non-standard Fortran code.

@ktbolt ktbolt self-assigned this Jul 15, 2022
@caseyfleeter
Copy link
Author

caseyfleeter commented Jul 21, 2022

That makes sense! I was just following the instructions from the file svSolver/BuildWithMake/README-build-linux.txt. This was the best practice when I first joined the lab, but may be outdated now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants