Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Losses to Reimplement and Test #23

Open
1 of 19 tasks
caseyfleeter opened this issue Feb 1, 2018 · 0 comments
Open
1 of 19 tasks

Minor Losses to Reimplement and Test #23

caseyfleeter opened this issue Feb 1, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request testing

Comments

@caseyfleeter
Copy link
Collaborator

caseyfleeter commented Feb 1, 2018

These minor loss models were originally available with the code, but they have not been tested so they were removed from the codebase. They could be reintegrated into the code but would need to be tested. After verifying the formulation gives correct results, Travis test cases would need to generated for the future.

Code re-integration: see commit 1e299f1 for the last instance with the following boundary conditions included. Note that code snippets will need to be copied from this commit and reintegrated manually, as there has been significant restructuring to the codebase that prevents a merge commit.

Regarding Travis: Run automatic test cases and compare them to analytical or numerical solutions (on Travis). Create a minimal test case for each feature of the solver and compare it to a previously computed solution. Whenever possible, use analytical solutions as a comparison.
Please modify the following lists accordingly:

  • add missing features
  • strikethrough removed features
  • check tested features

Reimplemented into code:

  • STENOSIS.
  • BRANCH_THROUGH_DIVIDING.
  • BRANCH_SIDE_DIVIDING.
  • BRANCH_THROUGH_CONVERGING.
  • BRANCH_SIDE_CONVERGING.
  • BIFURCATION_BRANCH.

Analytical/numerical solution generated:

  • STENOSIS.
  • BRANCH_THROUGH_DIVIDING.
  • BRANCH_SIDE_DIVIDING.
  • BRANCH_THROUGH_CONVERGING.
  • BRANCH_SIDE_CONVERGING.
  • BIFURCATION_BRANCH.

Travis test case(s) added:

  • STENOSIS.
  • BRANCH_THROUGH_DIVIDING.
  • BRANCH_SIDE_DIVIDING.
  • BRANCH_THROUGH_CONVERGING.
  • BRANCH_SIDE_CONVERGING.
  • BIFURCATION_BRANCH.
@caseyfleeter caseyfleeter added bug Something isn't working enhancement New feature or request question Further information is requested testing labels Feb 1, 2018
@caseyfleeter caseyfleeter added this to To Do in Testing OneDSolver for public release via automation Feb 1, 2018
@caseyfleeter caseyfleeter self-assigned this Feb 1, 2018
@caseyfleeter caseyfleeter changed the title Test Functionality of Minor Losses Minor Losses to Reimplement and Test Jun 1, 2020
@caseyfleeter caseyfleeter removed bug Something isn't working question Further information is requested labels Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
No open projects
Development

No branches or pull requests

1 participant