Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic app auth not working #1350

Open
tbi88 opened this issue Mar 11, 2024 · 3 comments
Open

dynamic app auth not working #1350

tbi88 opened this issue Mar 11, 2024 · 3 comments

Comments

@tbi88
Copy link

tbi88 commented Mar 11, 2024

Describe the bug
The docs state the following for the workflow execution API:

You can add dynamic app authentication when starting a workflow by using the following header: 'appauth'. Example: 'appauth: jira=auth for jira;elasticsearch=elasticsearch auth'. This works both with the name of the auth, and the ID.

I tried that but it seems not to work.

To Reproduce

  1. Create a workflow with an app which has some authenticaiton set.
  2. run the workflow via the API and set the appauth header.
    --> curl -XPOST -H "Authorization: Bearer secret" https://hostname/api/v1/workflows/6e7dc6cc-6cb9-4c32-98b6-3dddbc6738a8/execute -d '{"execution_argument": "test"}' -k -H "appauth: CrowdStrike=test-auth"

Expected behavior
appauth header should overwrite configured authentication in the workflow. Instead the workflow execution is run with the configured authentication. Setting no authentication on the node does also not change the behavior.

@frikky
Copy link
Member

frikky commented Mar 11, 2024

Describe the bug The docs state the following for the workflow execution API:

You can add dynamic app authentication when starting a workflow by using the following header: 'appauth'. Example: 'appauth: jira=auth for jira;elasticsearch=elasticsearch auth'. This works both with the name of the auth, and the ID.

I tried that but it seems not to work.

To Reproduce

  1. Create a workflow with an app which has some authenticaiton set.
  2. run the workflow via the API and set the appauth header.
    --> curl -XPOST -H "Authorization: Bearer secret" https://hostname/api/v1/workflows/6e7dc6cc-6cb9-4c32-98b6-3dddbc6738a8/execute -d '{"execution_argument": "test"}' -k -H "appauth: CrowdStrike=test-auth"

Expected behavior appauth header should overwrite configured authentication in the workflow. Instead the workflow execution is run with the configured authentication. Setting no authentication on the node does also not change the behavior.

I wonder whether this could be version based. @0x0elliot could you test out whether dynamic app auth works?

@tbi88
Copy link
Author

tbi88 commented Mar 15, 2024

I verified this works fine now in the latest nightly backend version for API calls. Curently not working for webhooks...

@frikky
Copy link
Member

frikky commented Mar 15, 2024

I verified this works fine now in the latest nightly backend version for API calls. Curently not working for webhooks...

Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants