Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken new embedded app authorization strategy url #1846

Closed
BaggioGiacomo opened this issue May 7, 2024 · 1 comment · Fixed by #1847
Closed

Broken new embedded app authorization strategy url #1846

BaggioGiacomo opened this issue May 7, 2024 · 1 comment · Fixed by #1847

Comments

@BaggioGiacomo
Copy link
Contributor

Issue summary

On this paragraph the new embedded app authorization strategy link redirects to a not found page since it doesn't exist a README.md in /shopify_app/docs/README.md.

The user should be redirected here instead

Expected behavior

I except to be redirected to the README on the New embedded app authorization strategy (Token Exchange) paragraph

Actual behavior

I'm being redirected to a Not found page

Steps to reproduce the problem

  1. Click on the new embedded app authorization strategy link on this paragraph
@sle-c sle-c linked a pull request May 7, 2024 that will close this issue
Fix new embedded app authorization strategy link redirect #1847
Merged
@sle-c
Copy link
Contributor

sle-c commented May 7, 2024 •
edited

PR opened for this issue #1847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix new embedded app authorization strategy link redirect BaggioGiacomo/shopify_app
2 participants
@sle-c @BaggioGiacomo