Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken with upcoming oauth2 2.0 gem #82

Open
troex opened this issue Sep 7, 2019 · 0 comments
Open

broken with upcoming oauth2 2.0 gem #82

troex opened this issue Sep 7, 2019 · 0 comments

Comments

@troex
Copy link

troex commented Sep 7, 2019

latest (master) version of oauth2 gem switched auth_scheme to basic_auth so it passes auth code in auth header instead see https://github.com/oauth-xx/oauth2/blob/4f57713f338bd8945ea7628a0f54660137c5c10c/CHANGELOG.md#unreleased

since omniauth-shopify-oauth2 depends on omniauth-oauth2 which depends on oauth2 - and all relay on "default" behaviour it is likely fail when oauth2 2.0 released.

Please set auth_scheme explicitly to request_body, this is easy to do with builder or inside the gem client_options:

use OmniAuth::Builder do
  provider :shopify, SHOPIFY_KEY, SHOPIFY_SECRET,
    client_options: {
      auth_scheme: :request_body
    }
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant