Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utf-8 validity tests to account for liquid checking encoding #219

Closed
wants to merge 1 commit into from

Conversation

zachmccormick
Copy link

Shopify/liquid#1774 introduced a pre-parsing check for valid UTF-8 encoding, and Shopify/liquid#1776 changed the raised exception to Liquid::TemplateEncodingError. This updates the failing test to look for the proper exception and message.

It may also be a valid outcome to remove this test entirely since this behavior is really part of https://github.com/Shopify/liquid and not the c extension

@ggmichaelgo
Copy link
Contributor

Hello @zachmccormick !
As you described on your PR, we could just remove test_invalid_utf8_sequence test.
Since the Liquid no longer allows templates with invalid UTF-8 byte sequence, this test is now obsolete.

@ggmichaelgo ggmichaelgo self-requested a review April 3, 2024 17:50
@ggmichaelgo
Copy link
Contributor

Closing this PR since #220 has been merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants