Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Query params are not added to requests that also have a body #1615

Open
andinica-idea opened this issue May 17, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working triage needs to be looked at

Comments

@andinica-idea
Copy link

Describe the bug

When trying to send a PUT/POST request using SHAFT's Request builder query params are not added to the request if the request also has a body.
If the request does not have a body, then query params are added.

To Reproduce

Steps to reproduce the behavior:

  1. Build a POST/PUT request with anything in the body (but not null) and some query params (again, not null)
  2. Send the request

Expected behavior

Request is sent with both body and query params.

Actual behavior
Request is sent only with body.

@andinica-idea andinica-idea added bug Something isn't working triage needs to be looked at labels May 17, 2024
@MohabMohie
Copy link
Contributor

Can you share a snippet of native code that's working for you dear?
Usually only one of the three is used. Form parameters, query parameters or body. So this was actually by design from our side and not a bug
But if we understand the reasoning we can enhance it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage needs to be looked at
Projects
None yet
Development

No branches or pull requests

2 participants