Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move random seed button away from start game button #63

Open
Sesu8642 opened this issue Aug 9, 2023 · 8 comments
Open

Move random seed button away from start game button #63

Sesu8642 opened this issue Aug 9, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@Sesu8642
Copy link
Owner

Sesu8642 commented Aug 9, 2023

Suggestion i received via email. It can happen relatively easily that you want to re-generate the map and then accidentally start the game. Should be already somewhat improved by the new gap between the buttons. But it shouldnt hurt to move the seed button further up.

@Sesu8642 Sesu8642 added the enhancement New feature or request label Aug 9, 2023
@Konebachirou
Copy link

Hello @Sesu8642, I want to participe on your project and try to fix this issue

@Sesu8642
Copy link
Owner Author

Hi @Konebachirou,
Thanks, I appretiate it! Let me know if you need some guidance. This is a good issue for a first contribution.
Please make sure you agree with the CLA before starting any work and sign it in your PR.

@Konebachirou
Copy link

Hello @Sesu8642, I work on Windows and I notice that to run the project you have to be on a Unix OS either lunix or mac so I would like to know if you have solutions for running it on Windows otherwise I can open an issue for that since I had to use a VM

@Sesu8642
Copy link
Owner Author

I do personally use Linux but I'm not aware of any issues on Windows. Can you please provide more details on what the problem is?

@Konebachirou
Copy link

when i try to run the project on windows i get compilation errors like
Could not get file details of C:\Users[usrname]\Desktop\FeudalTactics\core[C:\Users\Users[usrname]\Desktop\FeudalTactics\core\resources,
C:\Users\Users[usrname]\Desktop\FeudalTactics\core\build\generated\resources]: could not file attributes (errno 123)

@Sesu8642
Copy link
Owner Author

I could confirm this using a Win 11 VM with the latest Temurin 17. Will try to fix it soon but it doesn't seem to be trivial.

@Sesu8642
Copy link
Owner Author

@Konebachirou I pushed a change on master. Would you mind giving it a try? I tested in my VM but I had the feeling that I tried the same change before and it didn't work the first time.

@Konebachirou
Copy link

ok no problem i'ill try

Konebachirou added a commit to Konebachirou/FeudalTactics that referenced this issue Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants