Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very long activation time #23

Open
ziki77 opened this issue Apr 1, 2022 · 31 comments
Open

Very long activation time #23

ziki77 opened this issue Apr 1, 2022 · 31 comments

Comments

@ziki77
Copy link

ziki77 commented Apr 1, 2022

Hi,
the extension is good, but it takes a lot of time to activate:

image

Is this normal? Does it depend by the repo complexity?

Thanks

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

Welcome!

Thank you for finding time to write an issue and help to make this extension better. I`ll appreciate if you find some time to rate this extension here.

I`ll get to this Issue ASAP.

@Serhioromano
Copy link
Owner

This extension requires Git and Git-base core extensions you can see it in extension details page. It means that extension will not start activation until SCM is loaded. So, first after you launch VS Code it waits until SCM section loads and then it loads itself.

After CSM is loaded it might take a second, but after VS Code launch it will be definitely longer.

Anyway, thank you for nothing. If you like this extension, I'll appreciate if you rate it here
https://marketplace.visualstudio.com/items?itemName=Serhioromano.vscode-gitflow&ssr=false#review-details

@ziki77
Copy link
Author

ziki77 commented Apr 1, 2022

Sorry, but with Git Flow extension disabled the SCM section loads in half the time (7sec vs 14sec).

@Serhioromano
Copy link
Owner

What 14s?

@ziki77
Copy link
Author

ziki77 commented Apr 1, 2022

Yes but it is not the absolute value the problem, it is the difference. If it should take 1 sec more after the SCM is loaded it should be 8sec.
For SCM loaded I mean from when I launch VSC to when I can see the "Changes" in SCM.

@Serhioromano
Copy link
Owner

I'll try to check a performance.

@Serhioromano Serhioromano reopened this Apr 1, 2022
@Serhioromano
Copy link
Owner

I've created a small test with time measurements. It turns out that delay is command git remote to get list of all remotes. I think this is the problem. But it is essential for Git Flow to know if ORIGIN exists. It is better to have it once on load than every time before command.

I'll think how I can optimize this.

@Serhioromano
Copy link
Owner

Also if ORIGIN exists it pulls all tags from it

"git" ls-remote --tags origin

Also all branches

"git" branch -r

@ziki77
Copy link
Author

ziki77 commented Apr 1, 2022

And it depends on how many branches, tags, ecc the repo has, I think. I can try with a very simple repo.

@Serhioromano
Copy link
Owner

It might also depend on your connection speed. Give me 3 minutes I'll release new version where in the log you can see time what took most of the time.

@Serhioromano
Copy link
Owner

https://github.com/Serhioromano/vscode-gitflow/actions
Building right now.

@ziki77
Copy link
Author

ziki77 commented Apr 1, 2022

It might also depend on your connection speed. Give me 3 minutes I'll release new version where in the log you can see time what took most of the time.

Mmmm yes today I work from home through VPN, I will try next time in the office.

@Serhioromano
Copy link
Owner

Published. Give marketplace 2-3 minutes to approve. Version 1.3.3. Open OUTPUT and Git Flow stream, there should a time for every git command. Tell me what takes time.

@ziki77
Copy link
Author

ziki77 commented Apr 1, 2022

OK, thanks I will try and give you a feedback here.

@Serhioromano
Copy link
Owner

Any result?

@ziki77
Copy link
Author

ziki77 commented Apr 1, 2022

Yes, more or less 6 sec less. Well done!
In any case I think that my connection acts as bottleneck and causes also the 7 sec needed to load only the SCM. I will try in the office.

Thanks!

@Serhioromano
Copy link
Owner

Do not forget to rate. I need it badly. Very hard to get ranged in the beginning.

@ziki77
Copy link
Author

ziki77 commented Apr 1, 2022

Already done ;)

@ziki77
Copy link
Author

ziki77 commented Apr 5, 2022

Hi,
I tried in the office so in the same LAN of the git server. Without the extension it take 3sec to load SCM, with the extension enabled like from home after the latest fix (8-9sec).

@Serhioromano
Copy link
Owner

Hmmmm, I am going to look into it when I come back home from trip.

@Serhioromano Serhioromano reopened this Apr 18, 2022
@binarymaker
Copy link

binarymaker commented Oct 6, 2022

Due to gitflow extension my git repo detection under git tab takes very log time ~10s

@Serhioromano
Copy link
Owner

Due to gitflow extension my git repo detection under git tab takes very log time ~10s

I think it is because Git Flow also fetch remote branches if your repo have long history or many files it might take few seconds.

@osvaldont
Copy link

My gitflow takes a long time, in operations like creating start feature, start hotfix, I'm windows. Any suggestions on how to improve performance.

@Serhioromano
Copy link
Owner

My gitflow takes a long time, in operations like creating start feature, start hotfix, I'm windows. Any suggestions on how to improve performance.

Do you work in WSL?

@osvaldont
Copy link

No. I'm on windows.

@Serhioromano
Copy link
Owner

No. I'm on windows.

What is your repository? Is the size is big? You have HDD or SSSD?

@osvaldont
Copy link

My repository is small, it has only one class. My PC is SSD. To make a git flow init, it takes 6 minutes

@osvaldont
Copy link

Ha a delay too when you switch branches

@Serhioromano
Copy link
Owner

You mean delay when you run git flow init in a terminal? Then it is not related to my extension. It is a delay by GitFLow AVH

@osvaldont
Copy link

You're right. When I run git commands it's super fast, but when I run commands from the git flow extension, it's very slow. Any tips to make it faster?

@Serhioromano
Copy link
Owner

Serhioromano commented Aug 9, 2023

You're right. When I run git commands it's super fast, but when I run commands from the git flow extension, it's very slow. Any tips to make it faster?

Git commands or gitflow commands? I am sorry but I cannot reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants