Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ladybird: crash on github.com #23524

Closed
warpdesign opened this issue Mar 8, 2024 · 4 comments · Fixed by #23679
Closed

Ladybird: crash on github.com #23524

warpdesign opened this issue Mar 8, 2024 · 4 comments · Fixed by #23679

Comments

@warpdesign
Copy link
Contributor

warpdesign commented Mar 8, 2024 •
edited

Loading github.com doesn't seem to work anymore (on macOS):

Stack trace:

VERIFICATION FAILED: !m_has_scheduled_finish at /Users/nico/Documents/Dev/serenity/Userland/Libraries/LibHTTP/Job.cpp:582
0   liblagom-ak.0.0.0.dylib             0x0000000105eaaa3c ak_verification_failed + 172
1   liblagom-http.0.0.0.dylib           0x0000000104e631d0 HTTP::Job::finish_up() + 68
2   liblagom-http.0.0.0.dylib           0x0000000104e63140 HTTP::Job::timer_event(Core::TimerEvent&) + 44
3   liblagom-core.0.0.0.dylib           0x0000000105cced88 Core::EventReceiver::event(Core::Event&) + 104
4   liblagom-core.0.0.0.dylib           0x0000000105ccfce8 Core::EventReceiver::dispatch_event(Core::Event&, Core::EventReceiver*) + 220
5   liblagom-core.0.0.0.dylib           0x0000000105d221ac Core::ThreadEventQueue::process() + 952
6   liblagom-core.0.0.0.dylib           0x0000000105cc1384 Core::EventLoopImplementationUnix::pump(Core::EventLoopImplementation::PumpMode) + 40
7   liblagom-core.0.0.0.dylib           0x0000000105cc1358 Core::EventLoopImplementationUnix::exec() + 76
8   liblagom-core.0.0.0.dylib           0x0000000105cbdfc8 Core::EventLoop::exec() + 108
9   liblagom-tls.0.0.0.dylib            0x00000001059343dc TLS::TLSv12::connect(AK::ByteString const&, unsigned short, TLS::Options) + 724
10  RequestServer                       0x00000001046474b0 AK::ErrorOr<AK::NonnullOwnPtr<TLS::TLSv12>, AK::Error> RequestServer::ConnectionCache::Proxy::tunnel<TLS::TLSv12, TLS::TLSv12>(AK::URL const&) + 508
11  RequestServer                       0x00000001046b6844 decltype(auto) RequestServer::ConnectionCache::get_or_create_connection<AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>, AK::NonnullRefPtr<HTTP::HttpsJob>>(AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>&, AK::URL const&, AK::NonnullRefPtr<HTTP::HttpsJob>, Core::ProxyData) + 468
12  RequestServer                       0x00000001046b65f0 AK::OwnPtr<RequestServer::Request, AK::DefaultDelete<RequestServer::Request>> RequestServer::Detail::start_request<AK::Badge<RequestServer::HttpsProtocol>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>>(AK::Badge<RequestServer::HttpsProtocol>&&, int, RequestServer::ConnectionFromClient&, AK::ByteString const&, AK::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Span<unsigned char const>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>&&, Core::ProxyData)::'lambda'()::operator()() const + 320
13  RequestServer                       0x00000001046b62f4 AK::Function<void ()>::CallableWrapper<AK::OwnPtr<RequestServer::Request, AK::DefaultDelete<RequestServer::Request>> RequestServer::Detail::start_request<AK::Badge<RequestServer::HttpsProtocol>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>>(AK::Badge<RequestServer::HttpsProtocol>&&, int, RequestServer::ConnectionFromClient&, AK::ByteString const&, AK::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Span<unsigned char const>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>&&, Core::ProxyData)::'lambda'()>::call() + 28
14  RequestServer                       0x0000000104638ff4 AK::Function<void ()>::operator()() const + 312
15  liblagom-core.0.0.0.dylib           0x0000000105d2208c Core::ThreadEventQueue::process() + 664
16  liblagom-core.0.0.0.dylib           0x0000000105cc1384 Core::EventLoopImplementationUnix::pump(Core::EventLoopImplementation::PumpMode) + 40
17  liblagom-core.0.0.0.dylib           0x0000000105cc1358 Core::EventLoopImplementationUnix::exec() + 76
18  liblagom-core.0.0.0.dylib           0x0000000105cbdfc8 Core::EventLoop::exec() + 108
19  liblagom-tls.0.0.0.dylib            0x00000001059343dc TLS::TLSv12::connect(AK::ByteString const&, unsigned short, TLS::Options) + 724
20  RequestServer                       0x00000001046474b0 AK::ErrorOr<AK::NonnullOwnPtr<TLS::TLSv12>, AK::Error> RequestServer::ConnectionCache::Proxy::tunnel<TLS::TLSv12, TLS::TLSv12>(AK::URL const&) + 508
21  RequestServer                       0x0000000104646238 decltype(auto) RequestServer::ConnectionCache::get_or_create_connection<AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>, AK::NonnullRefPtr<RequestServer::Job>>(AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>&, AK::URL const&, AK::NonnullRefPtr<RequestServer::Job>, Core::ProxyData) + 468
22  RequestServer                       0x0000000104621a34 auto RequestServer::ConnectionFromClient::ensure_connection(AK::URL const&, RequestServer::CacheLevel const&)::$_1::operator()<AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>>(AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>&) const + 668
23  RequestServer                       0x0000000104620df4 RequestServer::ConnectionFromClient::ensure_connection(AK::URL const&, RequestServer::CacheLevel const&) + 688
24  RequestServer                       0x00000001046242a4 RequestServerStub::handle(IPC::Message const&) + 2276
25  liblagom-ipc.0.0.0.dylib            0x0000000104ee5e40 IPC::ConnectionBase::handle_messages() + 452
26  liblagom-ipc.0.0.0.dylib            0x0000000104ef0508 IPC::ConnectionBase::drain_messages_from_peer()::$_2::operator()() const + 84
27  liblagom-ipc.0.0.0.dylib            0x0000000104ef0330 AK::Function<void ()>::CallableWrapper<IPC::ConnectionBase::drain_messages_from_peer()::$_2>::call() + 28
28  RequestServer                       0x0000000104638ff4 AK::Function<void ()>::operator()() const + 312
29  liblagom-core.0.0.0.dylib           0x0000000105d2208c Core::ThreadEventQueue::process() + 664
30  liblagom-core.0.0.0.dylib           0x0000000105cc1384 Core::EventLoopImplementationUnix::pump(Core::EventLoopImplementation::PumpMode) + 40
31  liblagom-core.0.0.0.dylib           0x0000000105cc1358 Core::EventLoopImplementationUnix::exec() + 76
32  liblagom-core.0.0.0.dylib           0x0000000105cbdfc8 Core::EventLoop::exec() + 108
33  RequestServer                       0x0000000104619cc8 serenity_main(Main::Arguments) + 1164
34  RequestServer                       0x00000001046bd594 main + 464
35  dyld                                0x000000018c2690e0 start + 2360
@nico
Copy link
Collaborator

nico commented Mar 13, 2024

Does this still repro? IIRC @trflynn89 fixed some issues on macOS recently.

@trflynn89
Copy link
Member

Yeah I still see this occasionally.

@warpdesign
Copy link
Contributor Author

warpdesign commented Mar 14, 2024 •
edited

I could not reproduce the crash: github.com & github.com/SerenityOS/serenity both load properly.

This repo doesn't load though: it locks up (mouse cursor turns into the spinner and moving/clicking does nothing) but doesn't crash.

Screenshot 2024-03-14 at 12 11 35

The log shows lots of these:

2426751.103 WebContent(31418): Can't keep up! Skipping approximately 2 iteration(s) of a reloading timer (delayed by 29ms).
2426752.640 WebContent(31418): Can't keep up! Skipping approximately 3 iteration(s) of a reloading timer (delayed by 33ms).
2426752.715 WebContent(31418): Can't keep up! Skipping approximately 2 iteration(s) of a reloading timer (delayed by 28ms).
2426756.196 WebContent(31418): Can't keep up! Skipping approximately 3 iteration(s) of a reloading timer (delayed by 41ms).
2426757.649 WebContent(31418): Can't keep up! Skipping approximately 2 iteration(s) of a reloading timer (delayed by 28ms).
2426757.934 WebContent(31418): Can't keep up! Skipping approximately 2 iteration(s) of a reloading timer (delayed by 30ms).
2426757.997 WebContent(31418): Can't keep up! Skipping approximately 2 iteration(s) of a reloading timer (delayed by 31ms).
2426759.111 WebContent(31418): Can't keep up! Skipping approximately 2 iteration(s) of a reloading timer (delayed by 27ms).
2426759.171 WebContent(31418): Can't keep up! Skipping approximately 2 iteration(s) of a reloading timer (delayed by 29ms).
2426759.258 WebContent(31418): Can't keep up! Skipping approximately 3 iteration(s) of a reloading timer (delayed by 39ms).
2426759.982 WebContent(31418): Can't keep up! Skipping approximately 3 iteration(s) of a reloading timer (delayed by 37ms).
2426760.039 WebContent(31418): Can't keep up! Skipping approximately 2 iteration(s) of a reloading timer (delayed by 25ms).
2426760.095 WebContent(31418): Can't keep up! Skipping approximately 2 iteration(s) of a reloading timer (delayed by 25ms).
2426761.213 WebContent(31418): Can't keep up! Skipping approximately 1 iteration(s) of a reloading timer (delayed by 9ms).
2426761.271 WebContent(31418): Can't keep up! Skipping approximately 1 iteration(s) of a reloading timer (delayed by 10ms).
2426761.352 WebContent(31418): Can't keep up! Skipping approximately 3 iteration(s) of a reloading timer (delayed by 34ms).
2426761.515 WebContent(31418): Can't keep up! Skipping approximately 3 iteration(s) of a reloading timer (delayed by 35ms).
2426761.650 WebContent(31418): Can't keep up! Skipping approximately 3 iteration(s) of a reloading timer (delayed by 39ms).

Maybe I should create another issue?

alimpfard added a commit to alimpfard/serenity that referenced this issue Mar 22, 2024
@alimpfard
LibTLS: Avoid using new event loops when setting up connections
b4425de 
This was causing some racey behaviour in LibHTTP, and just generally
lead to really bad stack traces; avoid that by switching to
Core::Promise and using the existing event loop.

Possibly resolves SerenityOS#23524 and SerenityOS#23642.
@alimpfard alimpfard mentioned this issue Mar 22, 2024
Merged
awesomekling pushed a commit that referenced this issue Mar 22, 2024
@alimpfard @awesomekling
LibTLS: Avoid using new event loops when setting up connections
e2bab93 
This was causing some racey behaviour in LibHTTP, and just generally
lead to really bad stack traces; avoid that by switching to
Core::Promise and using the existing event loop.

Possibly resolves #23524 and #23642.
@warpdesign
Copy link
Contributor Author

I still get a crash with the latest commit when loading https://github.com/SerenityOS/serenity:

24875.488 WebContent(21046): Can't keep up! Skipping approximately 37 iteration(s) of a reloading timer (delayed by 36ms).
24875.887 RequestServer(21047): Loaded 145 of 145 (100%) provided CA Certificates
24892.905 RequestServer(21047): EnsureConnection: DNS-preload for github.githubassets.com
24892.924 RequestServer(21047): EnsureConnection: Pre-connect to https://github.githubassets.com/
24892.937 RequestServer(21047): EnsureConnection: DNS-preload for avatars.githubusercontent.com
24892.952 RequestServer(21047): EnsureConnection: DNS-preload for github-cloud.s3.amazonaws.com
24892.979 RequestServer(21047): EnsureConnection: DNS-preload for user-images.githubusercontent.com
24893.160 RequestServer(21047): EnsureConnection: Pre-connect to https://avatars.githubusercontent.com/
24893.887 RequestServer(21047): Can't keep up! Skipping approximately 1 iteration(s) of a reloading timer (delayed by 13ms).
24894.047 RequestServer(21047): Can't keep up! Skipping approximately 1 iteration(s) of a reloading timer (delayed by 10ms).
24894.128 RequestServer(21047): Can't keep up! Skipping approximately 1 iteration(s) of a reloading timer (delayed by 10ms).
24894.287 RequestServer(21047): Can't keep up! Skipping approximately 1 iteration(s) of a reloading timer (delayed by 10ms).
24894.394 RequestServer(21047): Can't keep up! Skipping approximately 1 iteration(s) of a reloading timer (delayed by 8ms).
24894.457 WebContent(21046): Can't keep up! Skipping approximately 12 iteration(s) of a reloading timer (delayed by 11ms).
24894.893 RequestServer(21047): Can't keep up! Skipping approximately 2 iteration(s) of a reloading timer (delayed by 99ms).
24894.893 RequestServer(21047): Can't keep up! Skipping approximately 2 iteration(s) of a reloading timer (delayed by 90ms).
24895.312 RequestServer(21047): Can't keep up! Skipping approximately 7 iteration(s) of a reloading timer (delayed by 320ms).
24895.312 RequestServer(21047): Can't keep up! Skipping approximately 7 iteration(s) of a reloading timer (delayed by 320ms).
VERIFICATION FAILED: !m_has_scheduled_finish at /Users/nico/Documents/Dev/serenity/Userland/Libraries/LibHTTP/Job.cpp:582
0   liblagom-ak.0.0.0.dylib             0x00000001059c7cc0 ak_verification_failed + 172
1   liblagom-http.0.0.0.dylib           0x000000010496b18c HTTP::Job::finish_up() + 68
2   liblagom-http.0.0.0.dylib           0x000000010496b0fc HTTP::Job::timer_event(Core::TimerEvent&) + 44
3   liblagom-core.0.0.0.dylib           0x00000001057ea0f4 Core::EventReceiver::event(Core::Event&) + 104
4   liblagom-core.0.0.0.dylib           0x00000001057eb054 Core::EventReceiver::dispatch_event(Core::Event&, Core::EventReceiver*) + 220
5   liblagom-core.0.0.0.dylib           0x000000010583e010 Core::ThreadEventQueue::process() + 952
6   liblagom-core.0.0.0.dylib           0x00000001057dc630 Core::EventLoopImplementationUnix::pump(Core::EventLoopImplementation::PumpMode) + 40
7   liblagom-core.0.0.0.dylib           0x00000001057d95a4 Core::EventLoop::pump(Core::EventLoop::WaitMode) + 120
8   liblagom-webview.0.0.0.dylib        0x0000000104e08db0 Core::Promise<AK::Empty, AK::Error>::await() + 80
9   liblagom-tls.0.0.0.dylib            0x000000010544e1e0 TLS::TLSv12::connect(AK::ByteString const&, unsigned short, TLS::Options) + 860
10  RequestServer                       0x000000010415416c AK::ErrorOr<AK::NonnullOwnPtr<TLS::TLSv12>, AK::Error> RequestServer::ConnectionCache::Proxy::tunnel<TLS::TLSv12, TLS::TLSv12>(URL::URL const&) + 508
11  RequestServer                       0x00000001041c1c50 decltype(auto) RequestServer::ConnectionCache::get_or_create_connection<AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>, AK::NonnullRefPtr<HTTP::HttpsJob>>(AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>&, URL::URL const&, AK::NonnullRefPtr<HTTP::HttpsJob>, Core::ProxyData) + 468
12  RequestServer                       0x00000001041c176c AK::OwnPtr<RequestServer::Request, AK::DefaultDelete<RequestServer::Request>> RequestServer::Detail::start_request<AK::Badge<RequestServer::HttpsProtocol>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>>(AK::Badge<RequestServer::HttpsProtocol>&&, int, RequestServer::ConnectionFromClient&, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Span<unsigned char const>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>&&, Core::ProxyData) + 2788
13  RequestServer                       0x00000001041c0c4c RequestServer::HttpsProtocol::start_request(int, RequestServer::ConnectionFromClient&, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Span<unsigned char const>, Core::ProxyData) + 268
14  RequestServer                       0x000000010412bcd0 RequestServer::ConnectionFromClient::start_request(int, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Detail::ByteBuffer<32ul> const&, Core::ProxyData const&) + 528
15  RequestServer                       0x0000000104130950 RequestServerStub::handle(IPC::Message const&) + 868
16  liblagom-ipc.0.0.0.dylib            0x00000001049ede40 IPC::ConnectionBase::handle_messages() + 452
17  liblagom-ipc.0.0.0.dylib            0x00000001049f8508 IPC::ConnectionBase::drain_messages_from_peer()::$_2::operator()() const + 84
18  liblagom-ipc.0.0.0.dylib            0x00000001049f8330 AK::Function<void ()>::CallableWrapper<IPC::ConnectionBase::drain_messages_from_peer()::$_2>::call() + 28
19  RequestServer                       0x0000000104145c8c AK::Function<void ()>::operator()() const + 312
20  liblagom-core.0.0.0.dylib           0x000000010583def0 Core::ThreadEventQueue::process() + 664
21  liblagom-core.0.0.0.dylib           0x00000001057dc630 Core::EventLoopImplementationUnix::pump(Core::EventLoopImplementation::PumpMode) + 40
22  liblagom-core.0.0.0.dylib           0x00000001057d95a4 Core::EventLoop::pump(Core::EventLoop::WaitMode) + 120
23  liblagom-webview.0.0.0.dylib        0x0000000104e08db0 Core::Promise<AK::Empty, AK::Error>::await() + 80
24  liblagom-tls.0.0.0.dylib            0x000000010544e1e0 TLS::TLSv12::connect(AK::ByteString const&, unsigned short, TLS::Options) + 860
25  RequestServer                       0x000000010415416c AK::ErrorOr<AK::NonnullOwnPtr<TLS::TLSv12>, AK::Error> RequestServer::ConnectionCache::Proxy::tunnel<TLS::TLSv12, TLS::TLSv12>(URL::URL const&) + 508
26  RequestServer                       0x00000001041c1c50 decltype(auto) RequestServer::ConnectionCache::get_or_create_connection<AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>, AK::NonnullRefPtr<HTTP::HttpsJob>>(AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>&, URL::URL const&, AK::NonnullRefPtr<HTTP::HttpsJob>, Core::ProxyData) + 468
27  RequestServer                       0x00000001041c176c AK::OwnPtr<RequestServer::Request, AK::DefaultDelete<RequestServer::Request>> RequestServer::Detail::start_request<AK::Badge<RequestServer::HttpsProtocol>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>>(AK::Badge<RequestServer::HttpsProtocol>&&, int, RequestServer::ConnectionFromClient&, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Span<unsigned char const>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>&&, Core::ProxyData) + 2788
28  RequestServer                       0x00000001041c0c4c RequestServer::HttpsProtocol::start_request(int, RequestServer::ConnectionFromClient&, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Span<unsigned char const>, Core::ProxyData) + 268
29  RequestServer                       0x000000010412bcd0 RequestServer::ConnectionFromClient::start_request(int, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Detail::ByteBuffer<32ul> const&, Core::ProxyData const&) + 528
30  RequestServer                       0x0000000104130950 RequestServerStub::handle(IPC::Message const&) + 868
31  liblagom-ipc.0.0.0.dylib            0x00000001049ede40 IPC::ConnectionBase::handle_messages() + 452
32  liblagom-ipc.0.0.0.dylib            0x00000001049f8508 IPC::ConnectionBase::drain_messages_from_peer()::$_2::operator()() const + 84
33  liblagom-ipc.0.0.0.dylib            0x00000001049f8330 AK::Function<void ()>::CallableWrapper<IPC::ConnectionBase::drain_messages_from_peer()::$_2>::call() + 28
34  RequestServer                       0x0000000104145c8c AK::Function<void ()>::operator()() const + 312
35  liblagom-core.0.0.0.dylib           0x000000010583def0 Core::ThreadEventQueue::process() + 664
36  liblagom-core.0.0.0.dylib           0x00000001057dc630 Core::EventLoopImplementationUnix::pump(Core::EventLoopImplementation::PumpMode) + 40
37  liblagom-core.0.0.0.dylib           0x00000001057d95a4 Core::EventLoop::pump(Core::EventLoop::WaitMode) + 120
38  liblagom-webview.0.0.0.dylib        0x0000000104e08db0 Core::Promise<AK::Empty, AK::Error>::await() + 80
39  liblagom-tls.0.0.0.dylib            0x000000010544e1e0 TLS::TLSv12::connect(AK::ByteString const&, unsigned short, TLS::Options) + 860
40  RequestServer                       0x000000010415416c AK::ErrorOr<AK::NonnullOwnPtr<TLS::TLSv12>, AK::Error> RequestServer::ConnectionCache::Proxy::tunnel<TLS::TLSv12, TLS::TLSv12>(URL::URL const&) + 508
41  RequestServer                       0x00000001041c1c50 decltype(auto) RequestServer::ConnectionCache::get_or_create_connection<AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>, AK::NonnullRefPtr<HTTP::HttpsJob>>(AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>&, URL::URL const&, AK::NonnullRefPtr<HTTP::HttpsJob>, Core::ProxyData) + 468
42  RequestServer                       0x00000001041c176c AK::OwnPtr<RequestServer::Request, AK::DefaultDelete<RequestServer::Request>> RequestServer::Detail::start_request<AK::Badge<RequestServer::HttpsProtocol>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>>(AK::Badge<RequestServer::HttpsProtocol>&&, int, RequestServer::ConnectionFromClient&, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Span<unsigned char const>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>&&, Core::ProxyData) + 2788
43  RequestServer                       0x00000001041c0c4c RequestServer::HttpsProtocol::start_request(int, RequestServer::ConnectionFromClient&, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Span<unsigned char const>, Core::ProxyData) + 268
44  RequestServer                       0x000000010412bcd0 RequestServer::ConnectionFromClient::start_request(int, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Detail::ByteBuffer<32ul> const&, Core::ProxyData const&) + 528
45  RequestServer                       0x0000000104130950 RequestServerStub::handle(IPC::Message const&) + 868
46  liblagom-ipc.0.0.0.dylib            0x00000001049ede40 IPC::ConnectionBase::handle_messages() + 452
47  liblagom-ipc.0.0.0.dylib            0x00000001049f8508 IPC::ConnectionBase::drain_messages_from_peer()::$_2::operator()() const + 84
48  liblagom-ipc.0.0.0.dylib            0x00000001049f8330 AK::Function<void ()>::CallableWrapper<IPC::ConnectionBase::drain_messages_from_peer()::$_2>::call() + 28
49  RequestServer                       0x0000000104145c8c AK::Function<void ()>::operator()() const + 312
50  liblagom-core.0.0.0.dylib           0x000000010583def0 Core::ThreadEventQueue::process() + 664
51  liblagom-core.0.0.0.dylib           0x00000001057dc630 Core::EventLoopImplementationUnix::pump(Core::EventLoopImplementation::PumpMode) + 40
52  liblagom-core.0.0.0.dylib           0x00000001057d95a4 Core::EventLoop::pump(Core::EventLoop::WaitMode) + 120
53  liblagom-webview.0.0.0.dylib        0x0000000104e08db0 Core::Promise<AK::Empty, AK::Error>::await() + 80
54  liblagom-tls.0.0.0.dylib            0x000000010544e1e0 TLS::TLSv12::connect(AK::ByteString const&, unsigned short, TLS::Options) + 860
55  RequestServer                       0x000000010415416c AK::ErrorOr<AK::NonnullOwnPtr<TLS::TLSv12>, AK::Error> RequestServer::ConnectionCache::Proxy::tunnel<TLS::TLSv12, TLS::TLSv12>(URL::URL const&) + 508
56  RequestServer                       0x00000001041c1c50 decltype(auto) RequestServer::ConnectionCache::get_or_create_connection<AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>, AK::NonnullRefPtr<HTTP::HttpsJob>>(AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>&, URL::URL const&, AK::NonnullRefPtr<HTTP::HttpsJob>, Core::ProxyData) + 468
57  RequestServer                       0x00000001041c176c AK::OwnPtr<RequestServer::Request, AK::DefaultDelete<RequestServer::Request>> RequestServer::Detail::start_request<AK::Badge<RequestServer::HttpsProtocol>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>>(AK::Badge<RequestServer::HttpsProtocol>&&, int, RequestServer::ConnectionFromClient&, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Span<unsigned char const>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>&&, Core::ProxyData) + 2788
58  RequestServer                       0x00000001041c0c4c RequestServer::HttpsProtocol::start_request(int, RequestServer::ConnectionFromClient&, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Span<unsigned char const>, Core::ProxyData) + 268
59  RequestServer                       0x000000010412bcd0 RequestServer::ConnectionFromClient::start_request(int, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Detail::ByteBuffer<32ul> const&, Core::ProxyData const&) + 528
60  RequestServer                       0x0000000104130950 RequestServerStub::handle(IPC::Message const&) + 868
61  liblagom-ipc.0.0.0.dylib            0x00000001049ede40 IPC::ConnectionBase::handle_messages() + 452
62  liblagom-ipc.0.0.0.dylib            0x00000001049f8508 IPC::ConnectionBase::drain_messages_from_peer()::$_2::operator()() const + 84
63  liblagom-ipc.0.0.0.dylib            0x00000001049f8330 AK::Function<void ()>::CallableWrapper<IPC::ConnectionBase::drain_messages_from_peer()::$_2>::call() + 28
64  RequestServer                       0x0000000104145c8c AK::Function<void ()>::operator()() const + 312
65  liblagom-core.0.0.0.dylib           0x000000010583def0 Core::ThreadEventQueue::process() + 664
66  liblagom-core.0.0.0.dylib           0x00000001057dc630 Core::EventLoopImplementationUnix::pump(Core::EventLoopImplementation::PumpMode) + 40
67  liblagom-core.0.0.0.dylib           0x00000001057d95a4 Core::EventLoop::pump(Core::EventLoop::WaitMode) + 120
68  liblagom-webview.0.0.0.dylib        0x0000000104e08db0 Core::Promise<AK::Empty, AK::Error>::await() + 80
69  liblagom-tls.0.0.0.dylib            0x000000010544e1e0 TLS::TLSv12::connect(AK::ByteString const&, unsigned short, TLS::Options) + 860
70  RequestServer                       0x000000010415416c AK::ErrorOr<AK::NonnullOwnPtr<TLS::TLSv12>, AK::Error> RequestServer::ConnectionCache::Proxy::tunnel<TLS::TLSv12, TLS::TLSv12>(URL::URL const&) + 508
71  RequestServer                       0x00000001041c1c50 decltype(auto) RequestServer::ConnectionCache::get_or_create_connection<AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>, AK::NonnullRefPtr<HTTP::HttpsJob>>(AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>&, URL::URL const&, AK::NonnullRefPtr<HTTP::HttpsJob>, Core::ProxyData) + 468
72  RequestServer                       0x00000001041c176c AK::OwnPtr<RequestServer::Request, AK::DefaultDelete<RequestServer::Request>> RequestServer::Detail::start_request<AK::Badge<RequestServer::HttpsProtocol>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>>(AK::Badge<RequestServer::HttpsProtocol>&&, int, RequestServer::ConnectionFromClient&, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Span<unsigned char const>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>&&, Core::ProxyData) + 2788
73  RequestServer                       0x00000001041c0c4c RequestServer::HttpsProtocol::start_request(int, RequestServer::ConnectionFromClient&, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Span<unsigned char const>, Core::ProxyData) + 268
74  RequestServer                       0x000000010412bcd0 RequestServer::ConnectionFromClient::start_request(int, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Detail::ByteBuffer<32ul> const&, Core::ProxyData const&) + 528
75  RequestServer                       0x0000000104130950 RequestServerStub::handle(IPC::Message const&) + 868
76  liblagom-ipc.0.0.0.dylib            0x00000001049ede40 IPC::ConnectionBase::handle_messages() + 452
77  liblagom-ipc.0.0.0.dylib            0x00000001049f8508 IPC::ConnectionBase::drain_messages_from_peer()::$_2::operator()() const + 84
78  liblagom-ipc.0.0.0.dylib            0x00000001049f8330 AK::Function<void ()>::CallableWrapper<IPC::ConnectionBase::drain_messages_from_peer()::$_2>::call() + 28
79  RequestServer                       0x0000000104145c8c AK::Function<void ()>::operator()() const + 312
80  liblagom-core.0.0.0.dylib           0x000000010583def0 Core::ThreadEventQueue::process() + 664
81  liblagom-core.0.0.0.dylib           0x00000001057dc630 Core::EventLoopImplementationUnix::pump(Core::EventLoopImplementation::PumpMode) + 40
82  liblagom-core.0.0.0.dylib           0x00000001057d95a4 Core::EventLoop::pump(Core::EventLoop::WaitMode) + 120
83  liblagom-webview.0.0.0.dylib        0x0000000104e08db0 Core::Promise<AK::Empty, AK::Error>::await() + 80
84  liblagom-tls.0.0.0.dylib            0x000000010544e1e0 TLS::TLSv12::connect(AK::ByteString const&, unsigned short, TLS::Options) + 860
85  RequestServer                       0x000000010415416c AK::ErrorOr<AK::NonnullOwnPtr<TLS::TLSv12>, AK::Error> RequestServer::ConnectionCache::Proxy::tunnel<TLS::TLSv12, TLS::TLSv12>(URL::URL const&) + 508
86  RequestServer                       0x00000001041c1c50 decltype(auto) RequestServer::ConnectionCache::get_or_create_connection<AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>, AK::NonnullRefPtr<HTTP::HttpsJob>>(AK::HashMap<RequestServer::ConnectionCache::ConnectionKey, AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>, AK::Traits<RequestServer::ConnectionCache::ConnectionKey>, AK::Traits<AK::NonnullOwnPtr<AK::Vector<AK::NonnullOwnPtr<RequestServer::ConnectionCache::Connection<TLS::TLSv12, TLS::TLSv12>>, 0ul>>>, false>&, URL::URL const&, AK::NonnullRefPtr<HTTP::HttpsJob>, Core::ProxyData) + 468
87  RequestServer                       0x00000001041c176c AK::OwnPtr<RequestServer::Request, AK::DefaultDelete<RequestServer::Request>> RequestServer::Detail::start_request<AK::Badge<RequestServer::HttpsProtocol>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>>(AK::Badge<RequestServer::HttpsProtocol>&&, int, RequestServer::ConnectionFromClient&, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Span<unsigned char const>, AK::ErrorOr<RequestServer::Protocol::Pipe, AK::Error>&&, Core::ProxyData) + 2788
88  RequestServer                       0x00000001041c0c4c RequestServer::HttpsProtocol::start_request(int, RequestServer::ConnectionFromClient&, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Span<unsigned char const>, Core::ProxyData) + 268
89  RequestServer                       0x000000010412bcd0 RequestServer::ConnectionFromClient::start_request(int, AK::ByteString const&, URL::URL const&, AK::HashMap<AK::ByteString, AK::ByteString, AK::Traits<AK::ByteString>, AK::Traits<AK::ByteString>, false> const&, AK::Detail::ByteBuffer<32ul> const&, Core::ProxyData const&) + 528
90  RequestServer                       0x0000000104130950 RequestServerStub::handle(IPC::Message const&) + 868
91  liblagom-ipc.0.0.0.dylib            0x00000001049ede40 IPC::ConnectionBase::handle_messages() + 452
92  liblagom-ipc.0.0.0.dylib            0x00000001049f8508 IPC::ConnectionBase::drain_messages_from_peer()::$_2::operator()() const + 84
93  liblagom-ipc.0.0.0.dylib            0x00000001049f8330 AK::Function<void ()>::CallableWrapper<IPC::ConnectionBase::drain_messages_from_peer()::$_2>::call() + 28
94  RequestServer                       0x0000000104145c8c AK::Function<void ()>::operator()() const + 312
95  liblagom-core.0.0.0.dylib           0x000000010583def0 Core::ThreadEventQueue::process() + 664
96  liblagom-core.0.0.0.dylib           0x00000001057dc630 Core::EventLoopImplementationUnix::pump(Core::EventLoopImplementation::PumpMode) + 40
97  liblagom-core.0.0.0.dylib           0x00000001057dc604 Core::EventLoopImplementationUnix::exec() + 76
98  liblagom-core.0.0.0.dylib           0x00000001057d9274 Core::EventLoop::exec() + 108
99  RequestServer                       0x00000001041268f4 serenity_main(Main::Arguments) + 1164
100 RequestServer                       0x00000001041c9788 main + 464
101 dyld                                0x00000001831610e0 start + 2360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LibTLS: Avoid using new event loops when setting up connections alimpfard/serenity
3 participants
@nico @warpdesign @trflynn89