Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"zone" in JSON input and output #37

Open
3 tasks
YohannsMonnier opened this issue May 19, 2014 · 1 comment
Open
3 tasks

"zone" in JSON input and output #37

YohannsMonnier opened this issue May 19, 2014 · 1 comment
Assignees
Milestone

Comments

@YohannsMonnier
Copy link

for JSON input, zone should be renamed in "sender zone" to be more explicit

for JSON output, clients_zone should be renamed in target_zones to be more explicit, an in plural because there could be a list of zone to target for the answer. I have not read the code, but sending "sender" as a parameter of the JSON output don't give the system the exact target and there should be a way to select later the right target, why not just put here the room name received in the input ?

  • Rewrite sender with the zone name to send the message to all clients in the zone
  • Rename variables INPUT zone=>sender_zone
  • Rename variables OUTPUT clients_zone=>target_zones
@Seraf Seraf added this to the LISA 1.0 milestone May 19, 2014
@Seraf Seraf added the accepted label Jun 1, 2014
@Seraf Seraf removed the accepted label Jun 28, 2014
@Seraf
Copy link
Owner

Seraf commented Aug 26, 2014

I have not read the code, but sending "sender" as a parameter of the JSON output don't give the system the exact target and there should be a way to select later the right target, why not just put here the room name received in the input ?

I used sender to be sure to reply only to the sender (the client who send a message). But it makes sense to rewrite it with the zones of the sender.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants