New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timed beliefs #79
Timed beliefs #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR.
I have no super-convicing case for naming, but my personal choice would be for simple words and to use them consistently in both libraries (you used search_all versus query_all and persist_all versus add_all).
I also have some questions about the implementations of the DB mixins. Probably will need a bit of discussion.
Thanks for your thoughts regarding method naming. I suggest the following:
This way, the naming reflects when you have to pass it a session explicitly, and the fm class method names won't overwrite the tb class method names, as they would if they are named exactly the same. Alternatively, it could be:
or:
But I prefer (and implemented) the first suggestion. |
This PR introduces the TimedBelief table and functionality to turn its entries into a BeliefsDataFrame and vice versa.
As part of your review, I'd be interested to get your opinion on the naming of the class methods I introduce for this functionality.
Best reviewed in conjunction with timely-beliefs PR 53.