Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI function for adding assets, weather sensors & add dummy market #74

Merged
merged 16 commits into from Apr 1, 2021
Merged

CLI function for adding assets, weather sensors & add dummy market #74

merged 16 commits into from Apr 1, 2021

Conversation

create-issue-branch[bot]
Copy link
Contributor

closes #57

@nhoening nhoening changed the title CLI function for adding assets and weather sensors CLI function for adding assets, weather sensors & add dummy market Mar 30, 2021
@nhoening nhoening marked this pull request as ready for review March 30, 2021 09:14
@nhoening nhoening requested a review from Flix6x March 30, 2021 14:05
Flix6x
Flix6x approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main comments:

  • Possible new issue about what data to delete when deleting users
  • Clear up what "structure" means

documentation/cli/commands.rst Outdated Show resolved Hide resolved
documentation/cli/commands.rst Outdated Show resolved Hide resolved
documentation/cli/commands.rst Outdated Show resolved Hide resolved
documentation/getting-started.rst Show resolved Hide resolved
documentation/cli/commands.rst Outdated Show resolved Hide resolved
flexmeasures/data/scripts/cli_tasks/data_add.py Show resolved Hide resolved
flexmeasures/data/scripts/data_gen.py Show resolved Hide resolved
flexmeasures/data/scripts/data_gen.py Outdated Show resolved Hide resolved
@nhoening nhoening merged commit f68d014 into main Apr 1, 2021
@nhoening nhoening deleted the issue-57-CLI_function_for_adding_assets_and_weather_sensors branch April 1, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening left review comments

@Flix6x Flix6x Flix6x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI function for adding assets and weather sensors
2 participants
@nhoening @Flix6x