Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support showing instantaneous sensor data with a custom event frequency #542

Merged
merged 41 commits into from Dec 12, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Nov 27, 2022

Upgrade timely-beliefs to expose new resampling functionality for instantaneous sensor data:

  • flexmeasures show beliefs can now handle showing (and saving) instantaneous sensor data and non-instaneous sensor data together.
  • /sensors/data now allows fetching instantaneous sensor data in a custom frequency, by using the "resolution" field. I've chosen to not (yet) expose a "frequency" field to the user API, but to keep only the "resolution" field. The resolution of the fetched data is now explicitly part of the return message, while the frequency is still implicit (i.e. the length of the data divided by the duration).

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added this to the 0.12.0 milestone Nov 27, 2022
@Flix6x Flix6x self-assigned this Nov 27, 2022
@coveralls
Copy link
Collaborator

coveralls commented Nov 27, 2022

Pull Request Test Coverage Report for Build 3674188427

  • 6 of 9 (66.67%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 64.929%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/api/common/schemas/sensor_data.py 6 9 66.67%
Files with Coverage Reduction New Missed Lines %
flexmeasures/api/common/schemas/sensor_data.py 2 78.64%
Totals Coverage Status
Change from base Build 3664805850: -0.02%
Covered Lines: 6644
Relevant Lines: 9596

💛 - Coveralls

@Flix6x Flix6x changed the title Upgrade timely-beliefs Support showing instantaneous sensor data with a custom event frequency Nov 28, 2022
…e up with default for instantaneous sensors

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…ent frequency

Signed-off-by: F.N. Claessen <felix@seita.nl>
…e None value

Signed-off-by: F.N. Claessen <felix@seita.nl>
…or UDI events

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…stantaneous sensors

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…rsion)

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…sample-instantaneous-sensor-data

# Conflicts:
#	flexmeasures/api/common/schemas/sensor_data.py
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x changed the base branch from main to 398-support-optional-source-in-sensorsdata-get November 29, 2022 12:11
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review November 29, 2022 13:04
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening November 29, 2022 13:21
Base automatically changed from 398-support-optional-source-in-sensorsdata-get to main December 2, 2022 10:32
Signed-off-by: F.N. Claessen <felix@seita.nl>

# Conflicts:
#	flexmeasures/api/common/schemas/sensor_data.py
#	flexmeasures/api/v3_0/sensors.py
#	flexmeasures/api/v3_0/tests/conftest.py
#	flexmeasures/api/v3_0/tests/test_sensor_data_fresh_db.py
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
# Conflicts:
#	documentation/changelog.rst
#	requirements/app.in
#	requirements/app.txt
@Flix6x Flix6x merged commit 46213bd into main Dec 12, 2022
@Flix6x Flix6x deleted the resample-instantaneous-sensor-data branch December 12, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants