Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI command to delete an asset #395

Merged
merged 4 commits into from Mar 21, 2022
Merged

CLI command to delete an asset #395

merged 4 commits into from Mar 21, 2022

Conversation

nhoening
Copy link
Contributor

This was the last missing command from project 14. I also do light refactoring.

@nhoening
simplify conformation dialogue coding in CLI commands for deletion
9c5dd1b 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening
add command: flexmeasures delete asset
4bf2a5e 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x March 19, 2022 23:31
@nhoening
document the command
90d70a0 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@coveralls
Copy link
Collaborator

coveralls commented Mar 19, 2022 •
edited

Pull Request Test Coverage Report for Build 2018121070

  • 7 of 21 (33.33%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 68.685%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/cli/data_delete.py 7 21 33.33%
Files with Coverage Reduction New Missed Lines %
flexmeasures/cli/data_delete.py 1 27.63%
Totals Coverage Status
Change from base Build 2009362347: 0.02%
Covered Lines: 6802
Relevant Lines: 9397
💛 - Coveralls

Flix6x
Flix6x approved these changes Mar 21, 2022
View reviewed changes
flexmeasures/cli/data_delete.py Show resolved Hide resolved
@nhoening
adjust another debugging statement
b911092 
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening merged commit f24c82d into main Mar 21, 2022
@nhoening nhoening deleted the cli-delete-asset branch March 21, 2022 20:16
@Flix6x Flix6x added this to the 0.9.0 milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nhoening @coveralls @Flix6x