Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first version of the toy scheduling tutorial #381

Merged
merged 17 commits into from Mar 7, 2022
Merged

first version of the toy scheduling tutorial #381

merged 17 commits into from Mar 7, 2022

Conversation

nhoening
Copy link
Contributor

@nhoening nhoening commented Mar 2, 2022

Run make update-docs to see it in action. It's linked from the start page of the documentation.

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@coveralls
Copy link
Collaborator

coveralls commented Mar 2, 2022

Pull Request Test Coverage Report for Build 1945722414

  • 3 of 5 (60.0%) changed or added relevant lines in 2 files are covered.
  • 284 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.6%) to 68.723%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/utils/config_utils.py 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
flexmeasures/utils/config_utils.py 1 30.28%
flexmeasures/data/models/planning/battery.py 2 92.19%
flexmeasures/data/models/planning/charging_station.py 2 86.36%
flexmeasures/data/services/scheduling.py 2 91.03%
flexmeasures/utils/unit_utils.py 2 91.3%
flexmeasures/data/models/planning/utils.py 5 83.76%
flexmeasures/data/schemas/sensors.py 8 70.83%
flexmeasures/data/schemas/generic_assets.py 10 80.0%
flexmeasures/data/models/generic_assets.py 22 71.08%
flexmeasures/data/models/annotations.py 24 57.14%
Totals Coverage Status
Change from base Build 1909581661: -0.6%
Covered Lines: 6754
Relevant Lines: 9330

💛 - Coveralls

…ials.

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…ciency encoding in percent

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x March 3, 2022 15:38
Flix6x and others added 10 commits March 4, 2022 22:24
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…ropriate code highlighting

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…ayed in the tutorial)

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
… set to a gate closure at noon

Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes and also configured a copy button for code snippets.

documentation/tut/toy-example-from-scratch.rst Outdated Show resolved Hide resolved
@Flix6x
Copy link
Contributor

Flix6x commented Mar 7, 2022

And also good to note: I successfully ran through your tutorial!

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
… TOMORROW variable

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening merged commit e2d54a9 into main Mar 7, 2022
@nhoening nhoening deleted the toy-tutorial branch March 7, 2022 13:42
sphinx_fontawesome==0.0.6
sphinx_copybutton==0.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, I couldn't find this file at first and then forgot about it. Why don't we move this file to our requirements folder, actually? Also, our main Makefile doesn't actually read in this requirements file, so either we fix that or we should add the copybutton extension there as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, make install-sphinx-tools can use that directly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged this already, so I'll change this spearately.

@Flix6x Flix6x added this to the 0.9.0 milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants