Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli command for adding a toy account #368

Merged
merged 13 commits into from Feb 25, 2022
Merged

Cli command for adding a toy account #368

merged 13 commits into from Feb 25, 2022

Conversation

nhoening
Copy link
Contributor

@nhoening nhoening commented Feb 20, 2022

The command flexmeasures add toy-account will add an account with three assets, one being a battery with a charging sensor.

This is useful as a starting point but also for a tutorial we are planning.

There are also two smaller improvements in CLI/data code:

  • simplify parameter names for IDs
  • using less session flushing

Fixes #367

…ing data

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
… user can otherwise not log in :/

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…ata CLI

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…f IDs

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
… dashboard

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening requested a review from Flix6x February 20, 2022 23:39
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@coveralls
Copy link
Collaborator

coveralls commented Feb 20, 2022

Pull Request Test Coverage Report for Build 1900740516

  • 15 of 40 (37.5%) changed or added relevant lines in 6 files are covered.
  • 40 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.3%) to 70.317%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flexmeasures/ui/charts/latest_state.py 2 3 66.67%
flexmeasures/cli/data_add.py 7 31 22.58%
Files with Coverage Reduction New Missed Lines %
flexmeasures/api/common/schemas/sensor_data.py 2 90.57%
flexmeasures/data/models/generic_assets.py 2 76.88%
flexmeasures/data/models/time_series.py 2 77.95%
flexmeasures/cli/data_add.py 34 34.6%
Totals Coverage Status
Change from base Build 1846065407: -0.3%
Covered Lines: 6691
Relevant Lines: 9054

💛 - Coveralls

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only, one of them a possible bug.

documentation/changelog.rst Outdated Show resolved Hide resolved
flexmeasures/cli/data_add.py Outdated Show resolved Hide resolved
flexmeasures/cli/data_delete.py Outdated Show resolved Hide resolved
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
… from review

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
@nhoening nhoening merged commit ca7e715 into main Feb 25, 2022
@nhoening nhoening deleted the cli-to-add-toy-account branch February 25, 2022 22:00
@Flix6x Flix6x added this to the 0.9.0 milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI command to add toy account
3 participants